address comments

pingcap · Feb 8, 2023 · b51b895 · b51b895
1 parent d780b5c
commit b51b895
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/dbms/src/Functions/LeastGreatest.h b/dbms/src/Functions/LeastGreatest.h
@@ -229,11 +229,10 @@ struct LeastGreatestStringImpl
             }
             else if (res == 0)
             {
-                size_t size = std::max(a_size, b_size);
                 if (a_size > b_size)
-                    res_ref[i] = StringRef(&a_data[0], size);
+                    res_ref[i] = StringRef(&a_data[0], a_size);
                 else
-                    res_ref[i] = StringRef(&b_data[0], size);
+                    res_ref[i] = StringRef(&b_data[0], b_size);
             }
             else
             {
@@ -575,7 +574,7 @@ class FunctionLeastGreatestString : public IFunction
                 block.getByPosition(result).column = std::move(col_str);
                 return;
             }
-        }  
+        }
     }
 
 private: