Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: better error message #133 #8950

Merged
merged 6 commits into from
Jan 7, 2019
Merged

parser: better error message #133 #8950

merged 6 commits into from
Jan 7, 2019

Conversation

lnhote
Copy link
Contributor

@lnhote lnhote commented Jan 4, 2019 •
edited
Loading

What problem does this PR solve?

Make parser error/warn message useful.
see pingcap/parser#86

What is changed and how it works?

  1. changed Errorf function, add more context.
  2. add/change testcases.
    see https://github.com/pingcap/parser/pull/133/files

Check List

Tests

  • Unit test

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

zz-jason
zz-jason reviewed Jan 5, 2019
View reviewed changes
@zz-jason
Copy link
Member

zz-jason commented Jan 5, 2019

Looks like we should merge pingcap/parser#133 first, then use the latest "pingcap/parser".

@zz-jason zz-jason added contribution This PR is from a community contributor. component/parser type/enhancement The issue or PR belongs to an enhancement. labels Jan 5, 2019
@lysu
Copy link
Contributor

lysu commented Jan 7, 2019

/run-all-tests

@lysu
Copy link
Contributor

lysu commented Jan 7, 2019

LGTM

@lysu lysu added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Jan 7, 2019
@lysu
Copy link
Contributor

lysu commented Jan 7, 2019

@tiancaiamao @jackysp PTAL

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@78a51a4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8950   +/-   ##
=========================================
  Coverage          ?   67.52%           
=========================================
  Files             ?      363           
  Lines             ?    75111           
  Branches          ?        0           
=========================================
  Hits              ?    50719           
  Misses            ?    19914           
  Partials          ?     4478

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78a51a4...d021275. Read the comment docs.

jackysp
jackysp approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit 39e1dfe into pingcap:master Jan 7, 2019
@breezewish
Copy link
Member

/run-integration-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
component/parser contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lnhote @CLAassistant @zz-jason @lysu @codecov-io @breezewish @jackysp