Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: better error message #133

Merged
merged 5 commits into from
Jan 6, 2019
Merged

parser: better error message #133

merged 5 commits into from
Jan 6, 2019

Conversation

lnhote
Copy link
Contributor

@lnhote lnhote commented Dec 28, 2018

see #86

@lnhote lnhote changed the title better error message (#1) parser: better error message (#1) Dec 28, 2018
@lnhote lnhote changed the title parser: better error message (#1) parser: better error message Dec 28, 2018
@ngaut
Copy link
Member

ngaut commented Jan 2, 2019

LGTM

@tiancaiamao
Copy link
Collaborator

PTAL @lysu

@lysu
Copy link
Collaborator

lysu commented Jan 4, 2019

Hi, @lnhote Thank you for your contribution!

LGTM but could you help us fire a PR in TiDB repo to test this then we can merge it.

Following Step 2: Make your parser changes take effect in TiDB and run CI in https://github.com/pingcap/parser/blob/master/README.md, thanks~

@lysu lysu added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Jan 4, 2019
@lysu lysu self-assigned this Jan 4, 2019
@ngaut ngaut merged commit 3483d83 into pingcap:master Jan 6, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants