Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: add arguments info for retry (#8506) #8509

Merged
merged 2 commits into from
Dec 3, 2018
Merged

session: add arguments info for retry (#8506) #8509

merged 2 commits into from
Dec 3, 2018

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Nov 29, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve?

Cherry-pick #8506 to master.

PTAL @lysu @tiancaiamao

This change is Reviewable

@jackysp jackysp added type/enhancement The issue or PR belongs to an enhancement. component/server labels Nov 29, 2018
@jackysp
Copy link
Member Author

jackysp commented Nov 29, 2018

/run-all-tests

1 similar comment
@jackysp
Copy link
Member Author

jackysp commented Nov 29, 2018

/run-all-tests

winkyao
winkyao reviewed Nov 30, 2018
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member Author

jackysp commented Nov 30, 2018

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

/build

@zhouqiang-cl
Copy link
Contributor

/run-all-test

@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@jackysp jackysp added status/all tests passed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2018
@jackysp
Copy link
Member Author

jackysp commented Dec 3, 2018

PTAL @tiancaiamao

lysu
lysu approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit bc7a315 into pingcap:master Dec 3, 2018
iamzhoug37 pushed a commit to iamzhoug37/tidb that referenced this pull request Dec 13, 2018
@jackysp @iamzhoug37
add args info for retry (pingcap#8506) (pingcap#8509)
09e9bb0
@jackysp jackysp deleted the retry_args branch April 4, 2019 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao winkyao left review comments

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
component/server status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackysp @zhouqiang-cl @lysu @winkyao