session: add arguments info for retry #8506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
tiancaiamao
approved these changes
Nov 29, 2018
|
/run-all-tests tidb-test=release-2.1 |
tiancaiamao
approved these changes
Nov 29, 2018
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Nov 29, 2018
jackysp
added a commit
that referenced
this pull request
Dec 3, 2018
iamzhoug37
pushed a commit
to iamzhoug37/tidb
that referenced
this pull request
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For binary execute statement, the arguments info are missing when the transaction is retrying.
What is changed and how it works?
Add the arguments info when retrying.
Check List
Tests
The log looks as the following, the arguments appare twice, due to TiDB doesn't reset arguments when retrying. Related to session: move more session vars to stmt context for retrying #8034
2018/11/29 14:14:23.300 session.go:497: [warning] con:7 schema_ver:24 retry_cnt:0 query_num:0 sql:update t set i = ? [arguments: 2, 2]
Code changes
Side effects
PTAL @lysu @tiancaiamao
This change is