Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mocktikv: update mvcc debug api. #6222

Merged
merged 6 commits into from
Apr 4, 2018
Merged

mocktikv: update mvcc debug api. #6222

merged 6 commits into from
Apr 4, 2018

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Apr 4, 2018

Please refer pingcap/kvproto#247 and tikv/tikv#2894 for more details.

@tiancaiamao
Copy link
Contributor

Please split vendor and update in different PRs, rest LGTM
This change has compatible problem, but it's just used for debugging purpose. @coocood @AndreMouche

@disksing
Copy link
Contributor Author

disksing commented Apr 4, 2018

Sadly I cannot split it. It won't compile with only vendor updates. @tiancaiamao

@disksing disksing removed the DNM label Apr 4, 2018
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreMouche AndreMouche merged commit 6395b58 into pingcap:master Apr 4, 2018
@disksing disksing deleted the mvcc-debug branch April 4, 2018 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants