Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mvcc debug api. #247

Merged
merged 3 commits into from
Apr 4, 2018
Merged

update mvcc debug api. #247

merged 3 commits into from
Apr 4, 2018

Conversation

disksing
Copy link
Contributor

Adjust the message structure to more accurately reflect the status of mvcc.

@siddontang
Copy link
Member

seem this break the compatibility, is it only used in tikv-ctl or other tools?

@disksing
Copy link
Contributor Author

disksing commented Apr 3, 2018

@siddontang http_handler in tidb also uses it. As it is only used for debug, I think it's ok to be incompatible during upgrade.

Copy link
Contributor

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddontang
Copy link
Member

LGTM

@disksing disksing removed the DNM Do Not Merge label Apr 4, 2018
@disksing disksing merged commit 2cf2492 into pingcap:master Apr 4, 2018
@disksing disksing deleted the debug-mvcc branch April 4, 2018 06:47
sticnarf pushed a commit to sticnarf/kvproto that referenced this pull request Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants