workloadrepo: Use better error codes for errors in the Workload Repository.

[wddevries]

What problem does this PR solve?

Issue Number: ref #58247

Problem Summary:
The workload repository currently returns ErrUnknown(1105) for all errors.

What changed and how does it work?

This pull request:

• adds an error message in createPartition() for failures when generating partition definitions
• adds error handing to generatePartitionDef()
• changes variable handers to return ErrWrongValueForVar when value parsing fails
• changes the workload repository to return ErrNotSupportedYet when enabled without an etcd server
• updates the variables test to validate the changes.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @wddevries. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 48.27586% with 15 lines in your changes missing coverage. Please review.

Project coverage is 74.1403%. Comparing base (9d0fb30) to head (e97aef7).
Report is 92 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #58866        +/-   ##
================================================
+ Coverage   73.1094%   74.1403%   +1.0308%     
================================================
  Files          1676       1686        +10     
  Lines        463866     479910     +16044     
================================================
+ Hits         339130     355807     +16677     
+ Misses       103877     103072       -805     
- Partials      20859      21031       +172     

Flag	Coverage Δ
integration	42.8798% <6.8965%> (?)
unit	72.8318% <48.2758%> (+0.5134%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (ø)
parser	∅ <ø> (∅)
br	47.0336% <ø> (+1.2886%)	⬆️

[bb7133]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bb7133,xhebox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-01-16 01:06:55.260222141 +0000 UTC m=+167086.715268275: ☑️ agreed by xhebox.
• 2025-01-23 00:17:24.279733896 +0000 UTC m=+312771.610653298: ☑️ agreed by bb7133.

[tiprow]

@wddevries: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tidb_parser_test	e97aef7	link	true	/test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.