-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix the issue that some extracted conditions are not used in information_schema #55236
Conversation
ref #55162. Similar issue I fixed before. |
Signed-off-by: Yang Keao <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55236 +/- ##
================================================
- Coverage 74.8025% 74.7098% -0.0927%
================================================
Files 1570 1570
Lines 364715 441512 +76797
================================================
+ Hits 272816 329853 +57037
- Misses 72132 91368 +19236
- Partials 19767 20291 +524
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@YangKeao: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
…n information_schema (pingcap#55236) close pingcap#55235
What problem does this PR solve?
Issue Number: close #55235
Problem Summary:
Some conditions are just not used in the retriever of information schema tables. This PR adds a test for them, and fixes these issues. These issues are introduced in #54333.
No matter whether an extracted condition is used in the real implementation, the parent executor will not use it to run a
SELECTION
again, and that's why these issues appear. It's hard to ensure all the conditions are used correctly, so I added a test to automatically test these lines.What changed and how does it work?
Check List
Tests
Release note