executor: filter on table_schema for INFORMATION_SCHEMA.KEY_COLUMN_USAGE table
#55162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note-none
|
/check-issue-triage-complete |
tangenta
reviewed
Aug 2, 2024
tangenta
approved these changes
Aug 2, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55162 +/- ##
================================================
+ Coverage 72.8356% 73.9979% +1.1622%
================================================
Files 1568 1568
Lines 439200 439203 +3
================================================
+ Hits 319894 325001 +5107
+ Misses 99604 94034 -5570
- Partials 19702 20168 +466
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lance6716
approved these changes
Aug 2, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
Signed-off-by: Yang Keao <[email protected]>
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #55156
Problem Summary:
Previously, the condition
table_schema = ...has no effect on tableINFORMATION_SCHEMA.KEY_COLUMN_USAGE. This PR fixed it.What changed and how does it work?
Also filter on
table_schemacondition.Maybe I can add more automatically generated tests for
InfoSchemaTablesExtractor🤔 later. We should verify that all these extracted columns work on all the information schema tables.Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.