-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: Optimized EXTRACT(<UNIT> FROM <partition_column>) for partition pruning. #54209
Conversation
Hi @mjonss. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54209 +/- ##
================================================
+ Coverage 72.8045% 75.4003% +2.5958%
================================================
Files 1568 1577 +9
Lines 439140 473670 +34530
================================================
+ Hits 319714 357149 +37435
+ Misses 99744 94858 -4886
- Partials 19682 21663 +1981
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: Hangjie Mo <[email protected]>
/retest |
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@mjonss: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #54210
Problem Summary:
the expression
EXTRACT(<time unit> FROM col)
is not handled for partition pruning.What changed and how does it work?
Treat the expression as prunable for all time units except WEEK (due to
default_week_format
).Meaning all prunable expressions will work with EQ/
col = <date/datetime/time>
.For DATE/DATETIME columns, it also optimizes YEAR and YEAR_MONTH to also work with ranges (<, <=, >, >=, BETWEEN), and for TIME columns it also optimizes HOUR, HOUR_MINUTE, HOUR_SECOND and HOUR_MICROSECOND for ranges.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.