*: remove CorrelatedCol.HashCode to avoid potential bug #45034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note-none
Signed-off-by: guo-shaoge <[email protected]>
wshwsh12
approved these changes
Jun 28, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/retest |
1 similar comment
|
/retest |
|
/test all |
Signed-off-by: guo-shaoge <[email protected]>
|
/test all |
12 tasks
Signed-off-by: guo-shaoge <[email protected]>
ti-chi-bot
bot
added
size/L
|
/retest |
5 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
AilinKid
approved these changes
Jun 30, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, wshwsh12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #45033
Problem Summary: Introduced by this pr: #44782 . #44782 add
CorrelatedColumn.HashCode, which will updateColumn.hashcode.rule_decorrelate, extract Column of CorrelatedColumn directly, check https://github.com/pingcap/tidb/blob/master/planner/core/rule_decorrelate.go#L215C44-L215C44 and https://github.com/pingcap/tidb/blob/master/expression/column.go#L177. The hashcode of Column has changed(it's the hash code of CorrelatedColumn instead the original Column)rule_eliminate_projection, planner will try to replace CondExpr in HashJoin by the output of Projection, here we use hashcode to decide whether to repace or not. But the hash code of CondExpr of HashJoin has changed, so the repacement didn't happen.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.