Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix the wrong ORDINAL_POSTITION in columns view #43491

Merged
merged 1 commit into from
May 3, 2023

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Apr 28, 2023

What problem does this PR solve?

Issue Number: close #43379

Problem Summary:

What is changed and how it works?

The change is actually quite simple(see the code).

the bug was introduced by me(#37419), and the root cause is that I didn't realize that filtering logic was pushed into hugeMemTableRetriever.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • None

Documentation

  • None

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that `ORDINAL_POSITION` from `information_schema.columns` is incorrect when filtering.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 28, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 29, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 2, 2023
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 2, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 1281be5

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 2, 2023
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 7eff8ce into pingcap:master May 3, 2023
@bb7133 bb7133 deleted the bb7133/fix_43379 branch December 29, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ORDINAL_POSITION from information_schema.columns is incorrect when filtering
3 participants