Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix incorrect ORDINAL_POSITION for INFORMAITON_SCHEMA.COLUMNS table #37419

Merged
merged 20 commits into from
Sep 6, 2022
Merged

executor: fix incorrect ORDINAL_POSITION for INFORMAITON_SCHEMA.COLUMNS table #37419

merged 20 commits into from
Sep 6, 2022

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Aug 28, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #31200

What is changed and how it works?

The root cause of #31200 is that when we calculate ORDINAL_POSITION for COLUMNS, the internally hidden columns used by 'expression index' is counted and the result will be wrong.

After this PR, hidden columns will not be counted.

Check List

Tests

Side effects

  • Breaking backward compatibility

Documentation

  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that when 'expression index' is defined, the value of `ORDINAL_POSITION` column of `INFORMAITON_SCHEMA`.`COLUMNS` table might be incorrect.

@bb7133 bb7133 added compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. compatibility-mysql80 This is a compatibility issue with MySQL 8.0(but NOT 5.7) labels Aug 28, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CbcWestwolf
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 28, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5c72585289ee3b00233217b04f744481d6faf897

@bb7133
Copy link
Member Author

bb7133 commented Aug 29, 2022

/run-mysql-test tidb-test=pr/1949

@bb7133
Copy link
Member Author

bb7133 commented Aug 29, 2022

PTAL @wjhuang2016 @xiongjiwei

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 29, 2022
wjhuang2016
wjhuang2016 reviewed Aug 29, 2022
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about KEY_COLUMN_USAGE?

@bb7133
Copy link
Member Author

bb7133 commented Aug 29, 2022

How about KEY_COLUMN_USAGE?

@wjhuang2016 It is irrelevant(https://dev.mysql.com/doc/refman/8.0/en/information-schema-key-column-usage-table.html):

The column's position within the constraint, not the column's position within the table.
This table provides no information about functional key parts because they are expressions and the table provides information only about columns.

The semantic of ORDINAL_POSTITION for KEY_COLUMN_USAGE is different with the one in COLUMNS.

@bb7133
Copy link
Member Author

bb7133 commented Sep 2, 2022

/run-mysql-test tidb-test=pr/1949

1 similar comment
@bb7133
Copy link
Member Author

bb7133 commented Sep 2, 2022

/run-mysql-test tidb-test=pr/1949

@bb7133
Copy link
Member Author

bb7133 commented Sep 2, 2022

/run-mysql-test tidb-test=pr/1949

@bb7133
Copy link
Member Author

bb7133 commented Sep 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 96323e7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 2, 2022
@hawkingrei
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2022
@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2022
@hawkingrei
Copy link
Member

/run-mysql-test tidb-test=pr/1949

@ti-chi-bot ti-chi-bot merged commit 77223af into pingcap:master Sep 6, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 6, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 4, success 13, total 17 13 min New failing
idc-jenkins-ci-tidb/common-test 🟥 failed 1, success 10, total 11 12 min New failing
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 5 min 45 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 56 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 57 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 26 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 13 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 3 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

This was referenced Apr 27, 2023
Closed
Merged
@bb7133 bb7133 deleted the bb7133/fix_31200 branch December 29, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees
No one assigned
Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. compatibility-mysql80 This is a compatibility issue with MySQL 8.0(but NOT 5.7) release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In information schema column table ORDINAL_POSITION is different
7 participants
@bb7133 @ti-chi-bot @sre-bot @hawkingrei @wjhuang2016 @CbcWestwolf @xiongjiwei