-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: check memory limit before allocate large memory in HashAgg #37013
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f05356f57b2780d12bf14b1c3ea56a78819cdef2
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 873228d
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/25e9126a37a2ea28c840cbdd9cceb6ed40758987 |
TiDB MergeCI notify🔴 Bad News! New failing [2] after this pr merged.
|
What problem does this PR solve?
Issue Number: ref #35635
close #40647
Problem Summary:
Now AggExec will expand the map first and then track the memory usage. May cause a lot of memory to be allocated at once before the SQL OOM action is taken.
We can move the tracking before the expand to avoid it.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.