Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check memory limit before allocate large memory in HashAgg #40647

Closed
wshwsh12 opened this issue Jan 17, 2023 · 0 comments · Fixed by #37013
Closed

Check memory limit before allocate large memory in HashAgg #40647

wshwsh12 opened this issue Jan 17, 2023 · 0 comments · Fixed by #37013
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@wshwsh12
Copy link
Contributor

Enhancement

TiDB use golang Map in some executor, e.g HashAgg. When the map expanding, memory usage can be 2-3 times. We should track the memory usage before allocating, to avoid TiDB OOM.
@wshwsh12 wshwsh12 added the type/enhancement The issue or PR belongs to an enhancement. label Jan 17, 2023
@wshwsh12 wshwsh12 mentioned this issue Jan 17, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: check memory limit before allocate large memory in HashAgg wshwsh12/tidb
1 participant
@wshwsh12