Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: support leading hint in join reorder optimization #34570
planner: support leading hint in join reorder optimization #34570
Changes from 26 commits
83a054c
b872695
427dc16
3d7ef8b
5bf862b
a46ada2
e7ded10
8631387
cdb8639
5402c20
f6f1eca
88a2bb1
919628c
867e379
3226deb
098ef46
1bd70df
2ec1a7c
150ad6f
bae8681
b3e0ed9
8bf2548
1fa1c8c
cf3b5a4
2ad7cf9
34ad152
6c03a66
3ddd5c9
19f8993
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems weird that update an inside field with an attached method like
_, s.otherConds = s.makeJoin(...)
...It's another problem and we can leave it unchanged here...