Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix test fail in TestHashRowContainer #33895

Merged
merged 3 commits into from
Apr 13, 2022
Merged

executor: fix test fail in TestHashRowContainer #33895

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21b160e
fix checkptr
wshwsh12 Apr 12, 2022
08dbb97
Merge branch 'master' into fix-testHashRowContainer
ti-chi-bot Apr 13, 2022
cb62a32
Merge branch 'master' into fix-testHashRowContainer
ti-chi-bot Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions executor/hash_table_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,14 +119,14 @@ func testHashRowContainer(t *testing.T, hashFunc func() hash.Hash64, spill bool)
chk1, _ := initBuildChunk(numRows)

hCtx := &hashContext{
allTypes: colTypes,
allTypes: colTypes[1:3],
keyColIdx: []int{1, 2},
}
hCtx.hasNull = make([]bool, numRows)
for i := 0; i < numRows; i++ {
hCtx.hashVals = append(hCtx.hashVals, hashFunc())
}
rowContainer := newHashRowContainer(sctx, 0, hCtx, hCtx.allTypes)
rowContainer := newHashRowContainer(sctx, 0, hCtx, colTypes)
copiedRC = rowContainer.ShallowCopy()
tracker := rowContainer.GetMemTracker()
tracker.SetLabel(memory.LabelForBuildSideResult)
Expand All @@ -150,7 +150,7 @@ func testHashRowContainer(t *testing.T, hashFunc func() hash.Hash64, spill bool)
probeChk, probeColType := initProbeChunk(2)
probeRow := probeChk.GetRow(1)
probeCtx := &hashContext{
allTypes: probeColType,
allTypes: probeColType[1:3],
keyColIdx: []int{1, 2},
}
probeCtx.hasNull = make([]bool, 1)
Expand Down