Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix test fail in TestHashRowContainer #33895

Merged
merged 3 commits into from
Apr 13, 2022
Merged

executor: fix test fail in TestHashRowContainer #33895

merged 3 commits into from
Apr 13, 2022

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Apr 12, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #30342

Problem Summary:

What is changed and how it works?

In hashContext, we need make allTypes one-to-one correspondence with keyColIdx. So update the test case to fix the fail.

Check List

Tests

  • Unit test
  • Integration test
  • [] Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Apr 12, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 12, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 12, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/cb62a32958c7aa4029a42de4918109ce56d10fcf

@wshwsh12 wshwsh12 requested a review from XuHuaiyu April 12, 2022 14:56
@tiancaiamao tiancaiamao mentioned this pull request Apr 13, 2022
Closed
@tiancaiamao
Copy link
Contributor

Close #30342

XuHuaiyu
XuHuaiyu approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2022
@wshwsh12
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 21b160e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2022
@wshwsh12
Copy link
Contributor Author

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit ce8cefa into pingcap:master Apr 13, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 13, 2022
@wshwsh12 @ti-srebot
cherry pick pingcap#33895 to release-5.1
60bf265 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2022
Closed
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33903

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 13, 2022
@wshwsh12 @ti-srebot
cherry pick pingcap#33895 to release-5.2
a559338 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2022
Closed
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33904

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 13, 2022
@wshwsh12 @ti-srebot
cherry pick pingcap#33895 to release-5.3
88355a3 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2022
Closed
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33905

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 13, 2022
@wshwsh12 @ti-srebot
cherry pick pingcap#33895 to release-5.4
e97cc44 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2022
Closed
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33906

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 13, 2022
@wshwsh12 @ti-srebot
cherry pick pingcap#33895 to release-6.0
02eab20 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2022
Closed
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

executor: checkptr: converted pointer straddles multiple allocations
6 participants
@wshwsh12 @ti-chi-bot @sre-bot @tiancaiamao @ti-srebot @XuHuaiyu