Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix wrong range calculation for Nulleq function on Enum values (#32440) #32494

Merged
merged 8 commits into from
Apr 15, 2022
Merged

planner: fix wrong range calculation for Nulleq function on Enum values (#32440) #32494

merged 8 commits into from
Apr 15, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Feb 21, 2022 •
edited
Loading

cherry-pick #32440 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/32494

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/32494:release-5.2-1b04c3b054c2

What problem does this PR solve?

Issue Number: close #32428

Problem Summary: planner: fix wrong range calculation for Nulleq function on Enum values

What is changed and how it works?

planner: fix wrong range calculation for Nulleq function on Enum values

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

planner: fix wrong range calculation for Nulleq function on Enum values

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 21, 2022
@ti-srebot ti-srebot mentioned this pull request Feb 21, 2022
Merged
12 tasks
@ti-srebot ti-srebot added sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.2-cherry-pick type/bugfix This PR fixes a bug. labels Feb 21, 2022
@ti-srebot
Copy link
Contributor Author

@qw4990 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 11, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 11, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 11, 2022
@winoros
Copy link
Member

winoros commented Apr 15, 2022

/merge

@ti-chi-bot
Copy link
Member

@winoros: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 15, 2022
@winoros
Copy link
Member

winoros commented Apr 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bc9e95532cd4736b0e77496821c5cb74b9776968

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2022
@winoros
Copy link
Member

winoros commented Apr 15, 2022

/merge

@winoros
Copy link
Member

winoros commented Apr 15, 2022

/run-mysql-test

@winoros
Copy link
Member

winoros commented Apr 15, 2022

/merge

@winoros
Copy link
Member

winoros commented Apr 15, 2022

/run-unit-test

1 similar comment
@winoros
Copy link
Member

winoros commented Apr 15, 2022

/run-unit-test

@winoros
Copy link
Member

winoros commented Apr 15, 2022

/merge

@winoros
Copy link
Member

winoros commented Apr 15, 2022

/run-unit-test

@winoros
Copy link
Member

winoros commented Apr 15, 2022

/merge

@qw4990 qw4990 force-pushed the release-5.2-1b04c3b054c2 branch from cad2d9c to a50824c Compare April 15, 2022 09:52
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2022
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2022
@winoros
Copy link
Member

winoros commented Apr 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7aa0cac

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/8474e405999e357b1a80046361bbe63bb4422b55

@time-and-fate
Copy link
Member

/run-unit-test

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit bed062b into pingcap:release-5.2 Apr 15, 2022
@zhouqiang-cl zhouqiang-cl added this to the v5.2.4 milestone Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees

@qw4990 qw4990

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.2-cherry-pick
Projects
None yet
Milestone
v5.2.4
Development

Successfully merging this pull request may close these issues.
9 participants
@ti-srebot @ti-chi-bot @winoros @sre-bot @time-and-fate @Reminiscent @qw4990 @VelocityLight @zhouqiang-cl