Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix wrong range calculation for Nulleq function on Enum values #32440

Merged
merged 6 commits into from
Feb 21, 2022
Merged

planner: fix wrong range calculation for Nulleq function on Enum values #32440

merged 6 commits into from
Feb 21, 2022

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Feb 17, 2022

What problem does this PR solve?

Issue Number: close #32428

Problem Summary: planner: fix wrong range calculation for Nulleq function on Enum values

What is changed and how it works?

planner: fix wrong range calculation for Nulleq function on Enum values

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

planner: fix wrong range calculation for Nulleq function on Enum values

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-cherry-pick-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed do-not-merge/needs-triage-completed labels Feb 17, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 17, 2022
qw4990
qw4990 commented Feb 17, 2022
View reviewed changes
planner/core/prepare_test.go
Comment on lines -2113 to -2114
// If the plan contains the tableDual, it can not be cached.
tk.MustQuery("select @@last_plan_from_cache").Check(testkit.Rows("0"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TableDual no longer exists after this PR.

@sre-bot
Copy link
Contributor

sre-bot commented Feb 18, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/509e838d451805bdb7fdd66fd780e24fb5aa0395

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 21, 2022
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e0bb285

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 21, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Feb 21, 2022

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Feb 21, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 1b04c3b into pingcap:master Feb 21, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 21, 2022
@qw4990 @ti-srebot
cherry pick pingcap#32440 to release-4.0
6ac0353 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Feb 21, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #32491

@ti-srebot ti-srebot mentioned this pull request Feb 21, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 21, 2022
@qw4990 @ti-srebot
cherry pick pingcap#32440 to release-5.0
26231e1 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #32492

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 21, 2022
@qw4990 @ti-srebot
cherry pick pingcap#32440 to release-5.1
f43de91 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Feb 21, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #32493

@ti-srebot ti-srebot mentioned this pull request Feb 21, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 21, 2022
@qw4990 @ti-srebot
cherry pick pingcap#32440 to release-5.2
38d3b41 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #32494

@ti-srebot ti-srebot mentioned this pull request Feb 21, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 21, 2022
@qw4990 @ti-srebot
cherry pick pingcap#32440 to release-5.3
4b09c19 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #32495

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 21, 2022
@qw4990 @ti-srebot
cherry pick pingcap#32440 to release-5.4
5e585f9 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Feb 21, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #32496

ti-chi-bot pushed a commit that referenced this pull request Feb 23, 2022
@ti-srebot
planner: fix wrong range calculation for Nulleq function on Enum valu…
62e62ff 
…es (#32440) (#32495)

close #32428
ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2022
@ti-srebot
planner: fix wrong range calculation for Nulleq function on Enum valu…
bed062b 
…es (#32440) (#32494)

close #32428
ti-chi-bot pushed a commit that referenced this pull request Apr 29, 2022
@ti-srebot
planner: fix wrong range calculation for Nulleq function on Enum valu…
c0f22ee 
…es (#32440) (#32496)

close #32428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@winoros winoros winoros approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generated wrong TableDual operator
6 participants
@qw4990 @ti-chi-bot @sre-bot @Reminiscent @ti-srebot @winoros