Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix different results for greatest when vectorized is off #29438

Merged
merged 6 commits into from
Nov 4, 2021
Merged

expression: fix different results for greatest when vectorized is off #29438

merged 6 commits into from
Nov 4, 2021

Conversation

guo-shaoge
Copy link
Collaborator

@guo-shaoge guo-shaoge commented Nov 4, 2021 •
edited
Loading

Signed-off-by: guo-shaoge [email protected]

What problem does this PR solve?

Issue Number: close #29434

Problem Summary:
The correct semantics of greatest/least(col_datetime, col_string):

  1. Convert all args as String
  2. EvalString to get arg value
  3. Parse string as datetime. If it's a valid datetime, use string(datetime) to compare. Otherwise use the result of EvalString to compare.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

expression: fix different results for greatest when vectorized is off.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 4, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 4, 2021
@guo-shaoge
Copy link
Collaborator Author

/run-common-test
/run-integration-copr-test
/run-integration-common-test

XuHuaiyu
XuHuaiyu approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 4, 2021
@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 labels Nov 4, 2021
@guo-shaoge
Copy link
Collaborator Author

/run-check_license

@guo-shaoge
Copy link
Collaborator Author

/cc @wshwsh12

@ti-chi-bot ti-chi-bot requested a review from wshwsh12 November 4, 2021 07:44
wshwsh12
wshwsh12 approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 4, 2021
@guo-shaoge
Copy link
Collaborator Author

/run-check_dev_2

@wshwsh12
Copy link
Contributor

wshwsh12 commented Nov 4, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 94d9d02

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 4, 2021
@guo-shaoge
Copy link
Collaborator Author

/run-check-license

@ti-chi-bot ti-chi-bot merged commit 8ae81b3 into pingcap:master Nov 4, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 4, 2021
@guo-shaoge @ti-srebot
cherry pick pingcap#29438 to release-5.3
f340890 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Nov 4, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #29455

@guo-shaoge
Copy link
Collaborator Author

/run-cherry-picker

ti-chi-bot pushed a commit that referenced this pull request Nov 5, 2021
@ti-srebot
expression: fix different results for greatest when vectorized is off (…
5fae7c5 
…#29438) (#29455)
@guo-shaoge
Copy link
Collaborator Author

/label needs-cherry-pick-4.0

@ti-srebot ti-srebot mentioned this pull request Nov 18, 2021
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 18, 2021
@guo-shaoge @ti-srebot
cherry pick pingcap#29438 to release-4.0
edfd5af 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #29916

@guo-shaoge
Copy link
Collaborator Author

/label needs-cherry-pick-5.0
/label needs-cherry-pick-5.1
/label needs-cherry-pick-5.2

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 18, 2021
@guo-shaoge @ti-srebot
cherry pick pingcap#29438 to release-5.0
be4c608 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Nov 18, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #29917

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 18, 2021
@guo-shaoge @ti-srebot
cherry pick pingcap#29438 to release-5.1
e9dd353 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Nov 18, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #29918

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 18, 2021
@guo-shaoge @ti-srebot
cherry pick pingcap#29438 to release-5.2
0d5d7db 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Nov 18, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #29919

ti-chi-bot pushed a commit that referenced this pull request Nov 22, 2021
@ti-srebot
expression: fix different results for greatest when vectorized is off (…
f77a86b 
…#29438) (#29916)
ti-chi-bot pushed a commit that referenced this pull request Dec 20, 2021
@ti-srebot
expression: fix different results for greatest when vectorized is off (…
6bfc667 
…#29438) (#29917)

close #29434
ti-chi-bot pushed a commit that referenced this pull request Feb 9, 2022
@ti-srebot
expression: fix different results for greatest when vectorized is off (…
bcfc749 
…#29438) (#29918)

close #29434
@bb7133 bb7133 mentioned this pull request Feb 17, 2022
Merged
14 tasks
ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2022
@ti-srebot
expression: fix different results for greatest when vectorized is off (…
aec80f9 
…#29438) (#29919)

close #29434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Results are different when tidb_enable_vectorized_expression is off
5 participants
@guo-shaoge @ti-chi-bot @wshwsh12 @ti-srebot @XuHuaiyu