Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: point get use lite resolve lock #26562

Merged
merged 3 commits into from
Sep 14, 2021
Merged

store/tikv: point get use lite resolve lock #26562

merged 3 commits into from
Sep 14, 2021

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing [email protected]

What problem does this PR solve?

Problem Summary: Point get does not use lite version of resolve lock any more. It was broken by previous code refactoring (#22732)

What is changed and how it works?

The fix is a cherry-pick of the client-go PR. (code in master branch is moved to standalone directory so we have to cherry-pick manually)

Check List

Tests

  • Unit test

Release note

  • Fix the issue that point get does not use lite version resolve lock

@disksing disksing requested a review from lysu July 26, 2021 08:46
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2021
@lysu lysu requested a review from AndreMouche July 26, 2021 09:53
@nolouch
Copy link
Member

nolouch commented Jul 28, 2021

Does it need to be fixed in v5.1.1?

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2021
@qw4990
Copy link
Contributor

qw4990 commented Sep 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 885280f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 14, 2021
@ti-chi-bot
Copy link
Member

@disksing: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit ca79ca0 into pingcap:release-5.1 Sep 14, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.1.2 milestone Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants