Skip to content

Commit

Permalink
store/tikv: point get use lite resolve lock
Browse files Browse the repository at this point in the history
Signed-off-by: disksing <[email protected]>
  • Loading branch information
disksing committed Jul 26, 2021
1 parent fb0eaf7 commit 885280f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion store/copr/coprocessor.go
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ func (it *copIterator) open(ctx context.Context, enabledRateLimitAction bool) {
respChan: it.respChan,
finishCh: it.finishCh,
vars: it.vars,
kvclient: tikv.NewClientHelper(it.store.store, it.resolvedLocks),
kvclient: tikv.NewClientHelper(it.store.store, it.resolvedLocks, false),
memTracker: it.memTracker,
replicaReadSeed: it.replicaReadSeed,
actionOnExceed: it.actionOnExceed,
Expand Down
3 changes: 2 additions & 1 deletion store/tikv/client_helper.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,13 @@ type ClientHelper struct {
}

// NewClientHelper creates a helper instance.
func NewClientHelper(store *KVStore, resolvedLocks *util.TSSet) *ClientHelper {
func NewClientHelper(store *KVStore, resolvedLocks *util.TSSet, resolveLockLite bool) *ClientHelper {
return &ClientHelper{
lockResolver: store.GetLockResolver(),
regionCache: store.GetRegionCache(),
resolvedLocks: resolvedLocks,
client: store.GetTiKVClient(),
resolveLite: resolveLockLite,
}
}

Expand Down
4 changes: 2 additions & 2 deletions store/tikv/snapshot.go
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ func (s *KVSnapshot) batchGetKeysByRegions(bo *Backoffer, keys [][]byte, collect
}

func (s *KVSnapshot) batchGetSingleRegion(bo *Backoffer, batch batchKeys, collectF func(k, v []byte)) error {
cli := NewClientHelper(s.store, s.resolvedLocks)
cli := NewClientHelper(s.store, s.resolvedLocks, false)
s.mu.RLock()
if s.mu.stats != nil {
cli.Stats = make(map[tikvrpc.CmdType]*RPCRuntimeStats)
Expand Down Expand Up @@ -483,7 +483,7 @@ func (s *KVSnapshot) get(ctx context.Context, bo *Backoffer, k []byte) ([]byte,
}
})

cli := NewClientHelper(s.store, s.resolvedLocks)
cli := NewClientHelper(s.store, s.resolvedLocks, true)

s.mu.RLock()
if s.mu.stats != nil {
Expand Down

0 comments on commit 885280f

Please sign in to comment.