-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: simplify LIKE patterns with multiple consecutive wildcards (#17490) #22572
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
@zz-jason please accept the invitation then you can push to the cherry-pick pull requests. |
this PR not only improve performance, but also fix a bug mysql> select 'aa' collate utf8mb4_general_ci like 'a_%a';
+---------------------------------------------+
| 'aa' collate utf8mb4_general_ci like 'a_%a' |
+---------------------------------------------+
| 0 |
+---------------------------------------------+
1 row in set (0.06 sec) this test case is added in PR #22558 |
/run-all-tests |
Sorry, make a mistake. This PR not fix the bug. |
@ti-srebot: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/close |
@xiongjiwei: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cherry-pick #17490 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/22572
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Problem Summary:
%% => %
and%_ => _%
are valid rewrite rules that improve pattern matching performance.This is a follow up to #17418 (comment) (cc @wjhuang2016).
What is changed and how it works?
What's Changed:
%% => %
and%_ => _%
.Related changes
Preceding: #17418
Check List
Tests
Moderate performance improvement for the affected cases:
Release note