-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
charset: implement utf8_unicode_ci and utf8mb4_unicode_ci collation (#18776) #22558
Merged
qw4990
merged 9 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-ba60cf5a69cf
Jan 28, 2021
Merged
charset: implement utf8_unicode_ci and utf8mb4_unicode_ci collation (#18776) #22558
qw4990
merged 9 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-ba60cf5a69cf
Jan 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
ti-srebot
added
component/executor
component/expression
contribution
This PR is from a community contributor.
sig/execution
SIG execution
sig/sql-infra
SIG: SQL Infra
type/4.0-cherry-pick
labels
Jan 27, 2021
@xiongjiwei you're already a collaborator in bot's repo. |
Please fix the conflict. |
# Conflicts: # expression/builtin_like_test.go
/run-all-tests |
wjhuang2016
reviewed
Jan 28, 2021
/run-all-tests |
wjhuang2016
reviewed
Jan 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
bb7133
approved these changes
Jan 28, 2021
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Jan 28, 2021
/run-all-tests |
@ti-srebot merge failed. |
Wait for #21877. |
/run-all-tests |
1 similar comment
/run-all-tests |
/run-integration-copr-test |
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/executor
component/expression
contribution
This PR is from a community contributor.
sig/execution
SIG execution
sig/sql-infra
SIG: SQL Infra
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18776 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/22558
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
This is the second PR of #17596 . This PR is aim to implement
utf8mb4_unicode_ci
andutf8mb4_unicode_ci
collation。What is changed and how it works?
What is changed:
How it Works:
xxx_unicode_ci
only use primary level (L1), it isai
andci
utf8mb4_unicode_ci
does not support contractions (see charset-unicode-sets-uca)benchmark
here is benchmark for
Compare
andKey
functionstring length
short
32Mid
2048Long
2097152Tests
Release note
utf8_unicode_ci
andutf8mb4_unicode_ci
collation