Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: fix panic in RegionStore.accessStore (#20204) #20210

Merged
merged 4 commits into from
Oct 3, 2020
Merged

tikv: fix panic in RegionStore.accessStore (#20204) #20210

merged 4 commits into from
Oct 3, 2020

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Sep 25, 2020

cherry-pick #20204 to release-4.0


What problem does this PR solve?

Issue Number: close #20181

Problem Summary:

see more in this comments #20181 (comment)

What is changed and how it works?

What's Changed, How it Works:

detect meta.Peer length change after sent fail, we can directly retry if length not match, because it must be another load or refill new cache info, we are no need to reload or change workIdx at this time

Related changes

  • Need to cherry-pick to the release branch 4.0

Check List

Tests

  • Unit test

Side effects

  • n/a

Release note

  • Fix panic in RegionStore.accessStore.

This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented Sep 25, 2020

/run-all-tests

@lysu lysu added type/bugfix This PR fixes a bug. status/PTAL labels Sep 25, 2020
@lysu lysu added this to the v4.0.8 milestone Sep 25, 2020
@coocood
Copy link
Member

coocood commented Sep 25, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 25, 2020
Copy link
Contributor

@bobotu bobotu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 25, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 25, 2020
@ti-srebot
Copy link
Contributor

@bobotu, @ti-srebot, @coocood, @lzmhhh123, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@bobotu, @ti-srebot, @coocood, @lzmhhh123, PTAL.

@lzmhhh123 lzmhhh123 removed their request for review September 30, 2020 06:06
@ti-srebot
Copy link
Contributor

@bobotu, @ti-srebot, @coocood, PTAL.

@zz-jason
Copy link
Member

zz-jason commented Oct 3, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 3, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 20297
  • 20293
  • 20155
  • 20074
  • 20252
  • 20240
  • 20248
  • 20249
  • 20216
  • 20154
  • 19944

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@lysu merge failed.

@zz-jason
Copy link
Member

zz-jason commented Oct 3, 2020

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 20240
  • 20248

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 4600ca1 into pingcap:release-4.0 Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants