Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: fix panic in RegionStore.accessStore #20204

Merged
merged 5 commits into from
Sep 25, 2020
Merged

tikv: fix panic in RegionStore.accessStore #20204

merged 5 commits into from
Sep 25, 2020

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Sep 24, 2020

What problem does this PR solve?

Issue Number: close #20181

Problem Summary:

see more in this comments #20181 (comment)

What is changed and how it works?

What's Changed, How it Works:

detect meta.Peer length change after sent fail, we can directly retry if length not match, because it must be another load or refill new cache info, we are no need to reload or change workIdx at this time

Related changes

  • Need to cherry-pick to the release branch 4.0

Check List

Tests

  • Unit test

Side effects

  • n/a

Release note

  • Fix panic in RegionStore.accessStore.

This change is Reviewable

@lysu lysu added the type/bugfix This PR fixes a bug. label Sep 24, 2020
@lysu
Copy link
Contributor Author

lysu commented Sep 24, 2020

/run-all-tests

@lysu
Copy link
Contributor Author

lysu commented Sep 24, 2020

/run-check_dev_2

@lysu
Copy link
Contributor Author

lysu commented Sep 24, 2020

/run-unit-test

@lysu lysu requested review from bobotu and coocood September 24, 2020 13:30
@lysu lysu added this to the v4.0.8 milestone Sep 24, 2020
@lysu lysu marked this pull request as ready for review September 24, 2020 13:31
@lysu lysu requested a review from lzmhhh123 September 24, 2020 13:31
Copy link
Contributor

@bobotu bobotu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 24, 2020
@coocood
Copy link
Member

coocood commented Sep 24, 2020

Do we need to recover the panic of startWorker goroutine?

@coocood
Copy link
Member

coocood commented Sep 25, 2020

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 25, 2020
@lysu
Copy link
Contributor Author

lysu commented Sep 25, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 25, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@lysu merge failed.

@lysu
Copy link
Contributor Author

lysu commented Sep 25, 2020

/run-check_dev_2

@lysu lysu merged commit e4f7bd7 into pingcap:master Sep 25, 2020
@lysu lysu deleted the dev-fix-out-of-range branch September 25, 2020 04:52
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 failed

@lysu
Copy link
Contributor Author

lysu commented Sep 25, 2020

/run-cherry-picker

@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tikv status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiDB panics when calling RegionStore.accessStore
4 participants