Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix show default num and sequence (#16450) #16526

Merged
merged 2 commits into from
Apr 17, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 17, 2020

cherry-pick #16450 to release-4.0


What problem does this PR solve?

close bug competition issue #17
fix the show result of default num and sequence

What is changed and how it works?

remove the quote when then default value is numeric and sequence expr

Check List

Tests

  • Unit test
  • Integration test

Release note: executor: fix show default num and sequence

@sre-bot sre-bot requested a review from a team as a code owner April 17, 2020 08:56
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 17, 2020

/run-all-tests

@AilinKid
Copy link
Contributor

/run-unit-test

1 similar comment
@AilinKid
Copy link
Contributor

/run-unit-test

@AilinKid
Copy link
Contributor

/run-check_dev

@AilinKid
Copy link
Contributor

/run-sqllogic-test-2

@AilinKid
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Apr 17, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 17, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 17, 2020

@sre-bot merge failed.

@AilinKid
Copy link
Contributor

/run-sqllogic-test-2

@zimulala zimulala merged commit dd56d1d into pingcap:release-4.0 Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants