Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix show default num and sequence #16450

Merged
merged 12 commits into from
Apr 17, 2020

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

close bug competition issue #17
fix the show result of default num and sequence

What is changed and how it works?

remove the quote when then default value is numeric and sequence expr

Check List

Tests

  • Unit test
  • Integration test

Release note: executor: fix show default num and sequence

@AilinKid AilinKid requested a review from a team as a code owner April 16, 2020 03:30
@ghost ghost requested review from wshwsh12 and removed request for a team April 16, 2020 03:30
@AilinKid AilinKid requested review from djshow832 and a team April 16, 2020 03:30
@ghost ghost removed their request for review April 16, 2020 03:31
@AilinKid AilinKid requested review from zimulala and a team April 16, 2020 03:31
@ghost ghost removed their request for review April 16, 2020 03:31
@AilinKid AilinKid added sig/execution SIG execution type/bugfix This PR fixes a bug. labels Apr 16, 2020
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Apr 16, 2020
@AilinKid AilinKid added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2020
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #16450 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #16450   +/-   ##
===========================================
  Coverage   80.4397%   80.4397%           
===========================================
  Files           506        506           
  Lines        136885     136885           
===========================================
  Hits         110110     110110           
  Misses        18190      18190           
  Partials       8585       8585           

@AilinKid
Copy link
Contributor Author

/run-unit-test

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

@AilinKid merge failed.

@wshwsh12 wshwsh12 removed their request for review April 16, 2020 05:59
@AilinKid
Copy link
Contributor Author

/run-all-tests

@AilinKid
Copy link
Contributor Author

/run-all-tests

@AilinKid
Copy link
Contributor Author

/run-all-tests

@AilinKid
Copy link
Contributor Author

/run-all-tests

@AilinKid
Copy link
Contributor Author

/run-check_dev_2

@AilinKid AilinKid merged commit 4e44a74 into pingcap:master Apr 17, 2020
@AilinKid
Copy link
Contributor Author

/run-cherry-picker

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 17, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 17, 2020

cherry pick to release-4.0 in PR #16526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants