Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: show correct result for system variable tidb_capture_plan_baselines (#16013) #16048

Merged
merged 2 commits into from
Apr 7, 2020

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Apr 3, 2020

cherry-pick #16013

@eurekaka eurekaka requested review from a team as code owners April 3, 2020 07:46
@ghost ghost requested review from francis0407 and XuHuaiyu April 3, 2020 07:46
@github-actions github-actions bot added sig/execution SIG execution sig/planner SIG: Planner labels Apr 3, 2020
@eurekaka eurekaka requested review from zz-jason and lzmhhh123 and removed request for XuHuaiyu and francis0407 April 3, 2020 07:53
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 3, 2020
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 7, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2020

Sorry @lzmhhh123, you don't have permission to trigger auto merge event on this branch.

@lzmhhh123 lzmhhh123 removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2020
@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2020

/run-all-tests

@zz-jason zz-jason merged commit 78922a8 into pingcap:release-4.0 Apr 7, 2020
@eurekaka eurekaka deleted the pick_sysvar branch April 7, 2020 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/bindinfo sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants