*: show correct result for system variable tidb_capture_plan_baselines #16013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
SunRunAway and
winoros
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #16013 +/- ##
===========================================
Coverage 80.5339% 80.5339%
===========================================
Files 506 506
Lines 135482 135482
===========================================
Hits 109109 109109
Misses 17870 17870
Partials 8503 8503 |
lzmhhh123
added
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
tidb_capture_plan_baselinesis a [server | global] scope system variable actually, but we don't handle it correctly inshow session variables like 'tidb_capture_plan_baselines'andselect @@session.tidb_capture_plan_baselines.Specifically, if we set this session variable to
onin one session, and then re-launch this session, in the new session, we find that the variable isoff, while actually in this TiDB process, the baseline capture is working.What is changed and how it works?
What's Changed:
Show server scope value in
show session variables/select @@session.tidb_capture_plan_baselines.Related changes
Check List
Tests
Side effects
N/A
Release note