store: update kvrpc.Cleanup proto and change its behaviour #12212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR, Cleanup always rollback a transaction if it's not committed. After this PR, Cleanup will not rollback a transaction if the lock is active.
Codecov Report
@@ Coverage Diff @@
## master #12212 +/- ##
===========================================
Coverage 81.2941% 81.2941%
===========================================
Files 454 454
Lines 100033 100033
===========================================
Hits 81321 81321
Misses 12926 12926
Partials 5786 5786 |
|
PTAL @MyonKeminta @coocood @lysu |
|
/run-all-tests |
coocood
reviewed
Sep 17, 2019
|
/run-all-tests tikv=pr/5471 |
MyonKeminta
reviewed
Sep 17, 2019
coocood
reviewed
Sep 18, 2019
|
LGTM |
|
/run-all-tests tikv=pr/5471 |
|
/run-all-tests tikv=pr/5471 |
|
/run-all-tests tikv=pr/5471 |
|
LGTM |
MyonKeminta
reviewed
Sep 23, 2019
MyonKeminta
approved these changes
Sep 23, 2019
|
/run-all-tests |
|
/run-unit-test |
|
cherry pick to release-3.0 failed |
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Sep 26, 2019
coocood
pushed a commit
that referenced
this pull request
Oct 9, 2019
|
It seems that, not for sure, we failed to cherry-pick this commit to release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @tiancaiamao PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Check the
TTLon the primary lock to decide the real status of a transaction.After we update the
TTLof a transaction, the TTL information on the secondary lock is not accurate.What is changed and how it works?
Before this PR, Cleanup always rollbacks a transaction if it's not committed.
After this PR, Cleanup will not rollback a transaction if the primary lock is active.
Check List
Tests
Side effects
The semantics of Cleanup API change.
Release note