-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/tikv: implement a ttlManager
to update the TTL of a transaction
#12177
Conversation
PTAL @coocood @MyonKeminta |
/run-unit-test |
1 similar comment
/run-unit-test |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
PTAL @lysu |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@tiancaiamao merge failed. |
/run-unit-test |
cherry pick to release-3.0 failed |
What problem does this PR solve?
In the pessimistic transaction and the large transaction, we should update the TTL of the lock.
What is changed and how it works?
Implement a
ttlManager
and use it in the pessimistic lock.The
ttlManager
will spawn a goroutine to update the TTL of the primary lock periodically.Check List
Tests
Side effects
Related changes
Release note