types: fix undefined behavior in numeric types cast (cast 1<<64 to uint64) #11968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: H-ZeX <[email protected]>
H-ZeX
added
type/bugfix
Signed-off-by: H-ZeX <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #11968 +/- ##
===========================================
Coverage ? 80.0309%
===========================================
Files ? 465
Lines ? 107336
Branches ? 0
===========================================
Hits ? 85902
Misses ? 14943
Partials ? 6491 |
Signed-off-by: H-ZeX <[email protected]>
Signed-off-by: H-ZeX <[email protected]>
|
/release |
ghost
requested review from
|
/build |
|
And do we also need to cherry pick this commit to release-3.1 |
…fix_ub_in_numeric_types
|
/run-all-tests |
|
@XuHuaiyu PTAL |
XuHuaiyu
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.1 failed |
|
@H-ZeX Please cherry-pick this PR manually. |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1 release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @lonng PTAL. |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 9, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-2.1 in PR #16238 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 9, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-3.0 in PR #16239 |
bb7133
pushed a commit
that referenced
this pull request
Apr 10, 2020
bb7133
pushed a commit
that referenced
this pull request
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: H-ZeX [email protected]
What problem does this PR solve?
In go-spec-conversions, there is this paragraph
so,
float64(1<<64)cast to uint64 is undefined behavor. although in current go compiler, it is(1<<63), which is not same as mysql5.7 does.Check List
Code changes
No.
Side effects
No.
Related changes