expression: fix incorrect proto fields and add missing overflow handling for arithmatic functions #12858

H-ZeX · 2019-10-21T16:04:29Z

Signed-off-by: H-ZeX [email protected]

What problem does this PR solve?

expression: Fix some bug of cast that detected by tikv/copr-test#4

What is changed and how it works?

There are some cast function that forget to handle the err using ctx, fix them by handle the err with ctx.
This sql select 1 / '2007' div 1; will fail with this err msg
For float(M,D), double(M,D) or decimal(M,D), M must be >= D (column '').
because in arithmeticDivideFunctionClass.setType4DivReal, it set the decimal to 31 while flen is 23. Then after builtinCastRealAsDecimalSig.evalDecimal is called , it will fail in ProduceDecWithSpecifiedTp
change in expression/builtin_arithmetic.go: Without this change, the errMsg is like
BIGINT UNSIGNED value is out of range in '(Column#1 - Column#2) , has no concrete number.
change in server/conn.go: Many error (such as errors.withStack)'s err field is of terror.Error type, but themeself are not of terror.Error type. So origin code will hide the origin err code. Same in store/mockstore/mocktikv/cop_handler_dag.go's toPBError.

Check List

Unit test
Integration test
Manual test (add detailed scripts or steps below)
- test in push-down-test: Add randgen arithmetic tests tikv/copr-test#3

Related changes

Need to cherry-pick to the release branch

Release note

Write release note for bug-fix or new feature.
TODO

Signed-off-by: H-ZeX <[email protected]>

zyxbest · 2019-10-21T19:10:47Z

/build

zyxbest · 2019-10-21T19:31:14Z

/rebuild

zyxbest · 2019-10-21T19:35:19Z

/run-all-tests

Signed-off-by: H-ZeX <[email protected]>

…t_bug-2

go.mod

Signed-off-by: H-ZeX <[email protected]>

…bug-2

Signed-off-by: H-ZeX <[email protected]>

H-ZeX · 2019-10-22T08:33:58Z

/tests

H-ZeX · 2019-10-22T08:34:34Z

/run-all-tests

Signed-off-by: H-ZeX <[email protected]>

H-ZeX · 2019-10-22T13:44:16Z

/run-all-tests

codecov · 2019-10-23T01:47:33Z

Codecov Report

Merging #12858 into master will decrease coverage by 0.0206%.
The diff coverage is 72.7272%.

@@               Coverage Diff                @@
##             master     #12858        +/-   ##
================================================
- Coverage   80.1454%   80.1247%   -0.0207%     
================================================
  Files           469        469                
  Lines        111239     111239                
================================================
- Hits          89153      89130        -23     
- Misses        15200      15224        +24     
+ Partials       6886       6885         -1

lonng · 2019-10-23T01:54:14Z

@qw4990 PTAL

lonng

LGTM

…bug-2

Deardrops

LGTM

lonng · 2019-11-06T09:16:12Z

/merge

sre-bot · 2019-11-06T09:16:16Z

Your auto merge job has been accepted, waiting for 13198, 13200

sre-bot · 2019-11-06T09:27:11Z

/run-all-tests

sre-bot · 2019-11-06T09:30:40Z

@H-ZeX merge failed.

lonng · 2019-11-06T09:32:07Z

/run-unit-test

sre-bot · 2019-11-06T09:39:50Z

cherry pick to release-3.0 failed

sre-bot · 2019-11-06T09:40:22Z

cherry pick to release-2.1 failed

sre-bot · 2019-11-06T09:40:52Z

cherry pick to release-3.1 failed

lonng · 2019-11-06T10:02:55Z

@H-ZeX Please cherry-pick this PR to 2.1/3.0/3.1.

…ing for arithmatic functions (pingcap#12858) Signed-off-by: H-ZeX <[email protected]>

sre-bot · 2020-04-07T10:24:33Z

It seems that, not for sure, we failed to cherry-pick this commit to release-2.1 release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @lonng PTAL.

reafans · 2020-04-09T10:17:20Z

/run-cherry-picker

Signed-off-by: sre-bot <[email protected]>

sre-bot · 2020-04-09T10:19:08Z

cherry pick to release-2.1 in PR #16245

Signed-off-by: sre-bot <[email protected]>

sre-bot · 2020-04-09T10:21:03Z

cherry pick to release-3.0 in PR #16246

…ing for arithmatic functions (#12858) (#16259)

…ing for arithmatic functions (#12858) (#16266)

backup

f956dbd

Signed-off-by: H-ZeX <[email protected]>

H-ZeX requested a review from a team as a code owner October 21, 2019 16:04

ghost requested review from wshwsh12 and removed request for a team October 21, 2019 16:04

Merge branch 'master' into fix_cast_bug-2

084413a

H-ZeX added 2 commits October 22, 2019 14:36

fix cast bug and add integration test

540cc84

Signed-off-by: H-ZeX <[email protected]>

Merge branch 'master' of https://github.com/pingcap/tidb into fix_cas…

50a5277

…t_bug-2

lonng reviewed Oct 22, 2019

View reviewed changes

go.mod Outdated Show resolved Hide resolved

H-ZeX added component/expression needs-cherry-pick-2.1 type/bugfix This PR fixes a bug. labels Oct 22, 2019

H-ZeX added 3 commits October 22, 2019 15:44

add integration test

7a834d8

Signed-off-by: H-ZeX <[email protected]>

Merge branch 'fix_cast_bug-2' of github.com:H-ZeX/tidb into fix_cast_…

be13c0b

…bug-2

fix compile err

b56d2f5

Signed-off-by: H-ZeX <[email protected]>

fix flag unset bug

af29684

Signed-off-by: H-ZeX <[email protected]>

Merge branch 'master' into fix_cast_bug-2

b770d37

Merge branch 'master' into fix_cast_bug-2

7114b83

lonng reviewed Oct 23, 2019

View reviewed changes

H-ZeX and others added 2 commits October 23, 2019 10:35

Merge branch 'fix_cast_bug-2' of github.com:H-ZeX/tidb into fix_cast_…

b596f70

…bug-2

Merge branch 'master' into fix_cast_bug-2

ef41e59

Deardrops approved these changes Nov 6, 2019

View reviewed changes

lonng approved these changes Nov 6, 2019

View reviewed changes

sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 6, 2019

Merge branch 'master' into fix_cast_bug-2

f2b86f4

lonng merged commit c01006a into pingcap:master Nov 6, 2019

lonng deleted the fix_cast_bug-2 branch November 6, 2019 09:39

fzhedu mentioned this pull request Dec 17, 2019

expression: solve bug when using string data in Div #14098

Merged

XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019

expression: fix incorrect proto fields and add missing overflow handl…

b19719a

…ing for arithmatic functions (pingcap#12858) Signed-off-by: H-ZeX <[email protected]>

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 9, 2020

cherry pick pingcap#12858 to release-2.1

5e6d83a

Signed-off-by: sre-bot <[email protected]>

sre-bot mentioned this pull request Apr 9, 2020

expression: fix incorrect proto fields and add missing overflow handling for arithmatic functions (#12858) #16245

Closed

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 9, 2020

cherry pick pingcap#12858 to release-3.0

2951ae8

Signed-off-by: sre-bot <[email protected]>

sre-bot mentioned this pull request Apr 9, 2020

expression: fix incorrect proto fields and add missing overflow handling for arithmatic functions (#12858) #16246

Closed

This was referenced Apr 9, 2020

expression: fix incorrect proto fields and add missing overflow handling for arithmatic functions (#12858) #16259

Merged

expression: fix incorrect proto fields and add missing overflow handling for arithmatic functions (#12858) #16266

Merged

sre-bot pushed a commit that referenced this pull request Apr 10, 2020

expression: fix incorrect proto fields and add missing overflow handl…

9a1f2c8

…ing for arithmatic functions (#12858) (#16259)

sre-bot pushed a commit that referenced this pull request Apr 10, 2020

expression: fix incorrect proto fields and add missing overflow handl…

93b3c07

…ing for arithmatic functions (#12858) (#16266)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

expression: fix incorrect proto fields and add missing overflow handling for arithmatic functions #12858

expression: fix incorrect proto fields and add missing overflow handling for arithmatic functions #12858

H-ZeX commented Oct 21, 2019 •

edited

Loading

zyxbest commented Oct 21, 2019

zyxbest commented Oct 21, 2019

zyxbest commented Oct 21, 2019

H-ZeX commented Oct 22, 2019

H-ZeX commented Oct 22, 2019

H-ZeX commented Oct 22, 2019

codecov bot commented Oct 23, 2019 •

edited

Loading

lonng commented Oct 23, 2019

lonng left a comment

Deardrops left a comment

lonng commented Nov 6, 2019

sre-bot commented Nov 6, 2019

sre-bot commented Nov 6, 2019

sre-bot commented Nov 6, 2019

lonng commented Nov 6, 2019

sre-bot commented Nov 6, 2019

sre-bot commented Nov 6, 2019

sre-bot commented Nov 6, 2019

lonng commented Nov 6, 2019

sre-bot commented Apr 7, 2020

reafans commented Apr 9, 2020

sre-bot commented Apr 9, 2020

sre-bot commented Apr 9, 2020

expression: fix incorrect proto fields and add missing overflow handling for arithmatic functions #12858

expression: fix incorrect proto fields and add missing overflow handling for arithmatic functions #12858

Conversation

H-ZeX commented Oct 21, 2019 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

zyxbest commented Oct 21, 2019

zyxbest commented Oct 21, 2019

zyxbest commented Oct 21, 2019

H-ZeX commented Oct 22, 2019

H-ZeX commented Oct 22, 2019

H-ZeX commented Oct 22, 2019

codecov bot commented Oct 23, 2019 • edited Loading

Codecov Report

lonng commented Oct 23, 2019

lonng left a comment

Choose a reason for hiding this comment

Deardrops left a comment

Choose a reason for hiding this comment

lonng commented Nov 6, 2019

sre-bot commented Nov 6, 2019

sre-bot commented Nov 6, 2019

sre-bot commented Nov 6, 2019

lonng commented Nov 6, 2019

sre-bot commented Nov 6, 2019

sre-bot commented Nov 6, 2019

sre-bot commented Nov 6, 2019

lonng commented Nov 6, 2019

sre-bot commented Apr 7, 2020

reafans commented Apr 9, 2020

sre-bot commented Apr 9, 2020

sre-bot commented Apr 9, 2020

H-ZeX commented Oct 21, 2019 •

edited

Loading

codecov bot commented Oct 23, 2019 •

edited

Loading