Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv: stabilize a test case (#11465) #11522

Merged
merged 2 commits into from
Jul 30, 2019
Merged

tikv: stabilize a test case (#11465) #11522

merged 2 commits into from
Jul 30, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Jul 30, 2019

What problem does this PR solve?

Cherry-pick #11465 to release 3.0.
The file store/tikv/client_fail_test.go is conflicted.

@jackysp jackysp requested review from lysu and tiancaiamao July 30, 2019 07:15
@jackysp
Copy link
Member Author

jackysp commented Jul 30, 2019

/run-all-tests

lysu
lysu approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ngaut
ngaut approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao tiancaiamao added the status/can-merge Indicates a PR has been approved by a committer. label Jul 30, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 30, 2019

/run-all-tests

@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 30, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 30, 2019

@jackysp merge failed.

@jackysp jackysp mentioned this pull request Jul 30, 2019
Merged
@jackysp jackysp closed this Jul 30, 2019
@jackysp jackysp reopened this Jul 30, 2019
@jackysp jackysp merged commit b96aa43 into pingcap:release-3.0 Jul 30, 2019
@jackysp jackysp deleted the stable_test_3.0 branch February 27, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu approved these changes

@ngaut ngaut ngaut approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
component/tikv status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jackysp @sre-bot @lysu @ngaut @tiancaiamao @hicqu