Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: stabilize a test case #11465

Merged
merged 6 commits into from
Jul 29, 2019
Merged

tikv: stabilize a test case #11465

merged 6 commits into from
Jul 29, 2019

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Jul 26, 2019

What problem does this PR solve?

An unstable test case

What is changed and how it works?

Stabilize the test case

Check List

Tests

  • no code

@hicqu hicqu requested review from XuHuaiyu and tiancaiamao July 26, 2019 10:20
@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #11465 into master will decrease coverage by 0.3992%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #11465        +/-   ##
================================================
- Coverage   81.7574%   81.3581%   -0.3993%     
================================================
  Files           424        424                
  Lines         92838      90812      -2026     
================================================
- Hits          75902      73883      -2019     
+ Misses        11620      11617         -3     
+ Partials       5316       5312         -4

@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #11465 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11465   +/-   ##
===========================================
  Coverage   81.8068%   81.8068%           
===========================================
  Files           424        424           
  Lines         92738      92738           
===========================================
  Hits          75866      75866           
  Misses        11538      11538           
  Partials       5334       5334

@lysu lysu changed the title stabilize a test case tikv: stabilize a test case Jul 26, 2019
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this commit can stabilize the test case?

@hicqu
Copy link
Contributor Author

hicqu commented Jul 29, 2019

@XuHuaiyu just because the order.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2019
@zz-jason zz-jason requested a review from XuHuaiyu July 29, 2019 03:15
@tiancaiamao
Copy link
Contributor

/run-all-tests

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Jul 29, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 29, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jul 29, 2019

@hicqu merge failed.

@jackysp jackysp merged commit 0f6a471 into pingcap:master Jul 29, 2019
@hicqu hicqu deleted the store-test-fix branch July 29, 2019 05:03
@sre-bot
Copy link
Contributor

sre-bot commented Jul 29, 2019

cherry pick to release-3.0 failed

jackysp pushed a commit to jackysp/tidb that referenced this pull request Jul 30, 2019
jackysp added a commit that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test component/tikv status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants