Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick table filters to 3.1 #372

Merged
merged 4 commits into from
Jul 9, 2020

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Jul 8, 2020

What problem does this PR solve?

Cherry-pick #341, #347, #353 to tidb-pump-3.1.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

kennytm and others added 3 commits July 8, 2020 17:22
* table-filter: implement .gitignore-style table filter

* table-filter: fix build error

Co-authored-by: Chunzhu Li <[email protected]>
…ter (#347)

* table-filter: added filter.All() to conveniently make a match-all filter

* table-filter: fix: NewSchemasFilter() should return the public interface
@kennytm kennytm force-pushed the cherry-pick-table-filters-to-3.1 branch from 0b07f4a to 32b6440 Compare July 8, 2020 09:23
@kennytm kennytm changed the base branch from release-3.1 to tidb-pump-3.1 July 8, 2020 09:23
@kennytm kennytm closed this Jul 8, 2020
@kennytm kennytm reopened this Jul 8, 2020
@kennytm
Copy link
Contributor Author

kennytm commented Jul 8, 2020

PTAL @3pointer @YuJuncen

Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Am I a reviewer of this repository?

@kennytm
Copy link
Contributor Author

kennytm commented Jul 9, 2020

Doesn't matter, you are a Reviewer in the SIG and the button is green 🙃

@kennytm kennytm merged commit 22f96cc into tidb-pump-3.1 Jul 9, 2020
@kennytm kennytm deleted the cherry-pick-table-filters-to-3.1 branch July 9, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants