table-filter: implement the new table filter #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 24, 2020
kennytm
added a commit
that referenced
this pull request
Jul 8, 2020
* table-filter: implement .gitignore-style table filter * table-filter: fix build error Co-authored-by: Chunzhu Li <[email protected]>
kennytm
added a commit
that referenced
this pull request
Jul 8, 2020
* table-filter: implement .gitignore-style table filter * table-filter: fix build error Co-authored-by: Chunzhu Li <[email protected]>
kennytm
added a commit
that referenced
this pull request
Jul 9, 2020
* table-filter: implement the new table filter (#341) * table-filter: implement .gitignore-style table filter * table-filter: fix build error Co-authored-by: Chunzhu Li <[email protected]> * table-filter: added filter.All() to conveniently make a match-all filter (#347) * table-filter: added filter.All() to conveniently make a match-all filter * table-filter: fix: NewSchemasFilter() should return the public interface * filter,table-filter: replace blacklist/whitelist by blocklist/allowlist (#353) * filter: fix build error Co-authored-by: Chunzhu Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement the new style table filter, to be used by BR and Dumpling, and to be replacing black-white-list in Lightning and DM.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes