Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/time range selector #1459

Merged
merged 5 commits into from
Jan 4, 2023
Merged

Conversation

YiniXu9506
Copy link
Contributor

image

@YiniXu9506 YiniXu9506 requested a review from shhdgit January 4, 2023 05:06
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 4, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shhdgit

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #1459 (ef1ec73) into master (a0f78b9) will increase coverage by 1.83%.
The diff coverage is n/a.

❗ Current head ef1ec73 differs from pull request most recent head c7c28f8. Consider uploading reports for the commit c7c28f8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1459      +/-   ##
==========================================
+ Coverage   27.58%   29.41%   +1.83%     
==========================================
  Files          93      128      +35     
  Lines        9978    10530     +552     
  Branches        0      103     +103     
==========================================
+ Hits         2752     3097     +345     
- Misses       7046     7253     +207     
  Partials      180      180              
Flag Coverage Δ
backend_ut 27.58% <ø> (ø)
e2e_test 62.50% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0f78b9...c7c28f8. Read the comment docs.

@YiniXu9506 YiniXu9506 merged commit 194d3e0 into pingcap:master Jan 4, 2023
@YiniXu9506 YiniXu9506 deleted the fix/TimeRangeSelector branch January 4, 2023 09:29
shhdgit pushed a commit to shhdgit/tidb-dashboard that referenced this pull request Feb 9, 2023
* chore: update time limit level

* chore: update time limit level

* chore: update time range selector no overview page

* chore: update tidb dashboard for clinic cloud version
shhdgit added a commit that referenced this pull request Feb 9, 2023
* feat: limit date picker range (#1429)

* feat: limit date picker range

* chore: update version for dbaas and clinic

* chore: hide zoomOut feature for timeSelector on cloud side

* chore: set max timeRange for monitoring as two days

* Feat/slowquery v2 (#1449)

* feat: init slow query v2

* tweak: use slow query module

* feat: comparison

* tweak: comparison

* wip

* tweak: comparison

* tweak: comparison

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* update version

* wip

* wip

* fix: url params

* update version

* update version

* fix: deps

* fix: deps version

* chore: tsconfig

* revert: deps version

* wip

* fix: request

* wip: deps

* fix: v2 detail history back

* fix: v2 detail history back

* tweak: url params

* fix: memo url time range

* fix: memo url time range

* fix: conprof

* chore: time range

* update deps

* chore

* chore

* chore

* update copyright

* skip e2e

* Fix/time range selector (#1459)

* chore: update time limit level

* chore: update time limit level

* chore: update time range selector no overview page

* chore: update tidb dashboard for clinic cloud version

* centos7 build image

* cleanup dockerfiles

* Revert mistake commits (#1465)

* Revert "cleanup dockerfiles"

This reverts commit 98f0964.

* Revert "centos7 build image"

This reverts commit 320b30c.

* Centos7 dockerfile; fix tests (#1467)

* centos7 build image

(cherry picked from commit 320b30c)

* cleanup dockerfiles

(cherry picked from commit 98f0964)

* fix centos7 build; fix test

* fix test

* chore: update tooltip when failed to get host info (#1469)

- because the reason is not correct in some cases

* chore: add serverless monitoring (#1462)

* chore: add serverless monitoring

* chore: remove category from serverless category

* chore: refine code and update failed query promql

* chore: update promql

* fix: time range limit on time range selector

* fix: date should be available if there are available hours on this date

* chore: update time limit

* chore: fix slowquery rout prefix

* chore: fix route prefix of diagnosis app

* fix(topsql): short format (#1476)

* feat(slowquery): add warnings (#1472)

* feat(slowquery): add warnings

* fix: lint generic

* chore: types

* fix: test

* fix: test

* fix: tests

* [Feature] Manually bind execution plan (#1473)

* Backend for binding sql plan feature (#1471)

* default version value for local quick startup

* update CONTRIBUTING.md

* done backend

* fix swag doc

* fix query bug

* done

* fix feature version check

* fix lint

* revert swagger tag

* fix 404 response (#1474)

* fix null response

* fix get plan response; fix drop plan behavior.

* fix

* fix dockerfile

* fix supported version check

* Add one-click bind plan on sql statement detail page (#1475)

* chore: add plan bind api

* chore: add plan bind modal

* chore: destory modal content on close

* chore: fix plan table selection

* chore: update plan bind style

* chore: add i18n to bind plan

* chore: set selection as radio on plan bind table

* chore: update plan selection status

* chore: set plan list order by plan count

* chore: refine code

* chore: refine code

* replace reflection go-funk with generic lo; add more fields to query plan response

* update swag

* add error message

* fix format

* chore: update enable plan binding condition

* fix tests

* chore: update go.mod

* chore: refine code

* fix centos7 dockerfile

* fix typo

---------

Co-authored-by: Yini Xu <[email protected]>
Co-authored-by: YiniXu9506 <[email protected]>
Co-authored-by: Suhaha <[email protected]>

* Update release version

---------

Co-authored-by: Yini Xu <[email protected]>
Co-authored-by: Yifan Xu <[email protected]>
Co-authored-by: Sparkle <[email protected]>
Co-authored-by: YiniXu9506 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants