feat: limit date picker range #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1429 +/- ##
==========================================
+ Coverage 26.19% 29.41% +3.21%
==========================================
Files 202 128 -74
Lines 15405 10530 -4875
Branches 103 103
==========================================
- Hits 4035 3097 -938
+ Misses 11099 7253 -3846
+ Partials 271 180 -91
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
shhdgit
approved these changes
Oct 27, 2022
|
Let's remove the JIRA issue link because external people can't access it, we can attach the JIRA issue link in the clinic repo side PR and link to this PR. |
baurine
reviewed
Oct 27, 2022
ui/packages/tidb-dashboard-lib/src/components/TimeRangeSelector/index.tsx
Outdated
Show resolved
Hide resolved
ui/packages/tidb-dashboard-lib/src/components/TimeRangeSelector/index.tsx
Outdated
Show resolved
Hide resolved
ui/packages/tidb-dashboard-lib/src/components/TimeRangeSelector/index.tsx
Outdated
Show resolved
Hide resolved
Got it. |
|
Did we miss the package.json file change? |
baurine
reviewed
Oct 28, 2022
ui/packages/tidb-dashboard-lib/src/components/TimeRangeSelector/index.tsx
Outdated
Show resolved
Hide resolved
baurine
reviewed
Oct 28, 2022
ui/packages/tidb-dashboard-lib/src/components/TimeRangeSelector/index.tsx
Outdated
Show resolved
Hide resolved
baurine
reviewed
Oct 28, 2022
ui/packages/tidb-dashboard-lib/src/components/TimeRangeSelector/index.tsx
Outdated
Show resolved
Hide resolved
|
Holding this PR and waiting for notification. |
shhdgit
approved these changes
Dec 28, 2022
shhdgit
pushed a commit
to shhdgit/tidb-dashboard
that referenced
this pull request
Feb 9, 2023
* feat: limit date picker range * chore: update version for dbaas and clinic * chore: hide zoomOut feature for timeSelector on cloud side * chore: set max timeRange for monitoring as two days
shhdgit
added a commit
that referenced
this pull request
Feb 9, 2023
* feat: limit date picker range (#1429) * feat: limit date picker range * chore: update version for dbaas and clinic * chore: hide zoomOut feature for timeSelector on cloud side * chore: set max timeRange for monitoring as two days * Feat/slowquery v2 (#1449) * feat: init slow query v2 * tweak: use slow query module * feat: comparison * tweak: comparison * wip * tweak: comparison * tweak: comparison * wip * wip * wip * wip * wip * wip * wip * update version * wip * wip * fix: url params * update version * update version * fix: deps * fix: deps version * chore: tsconfig * revert: deps version * wip * fix: request * wip: deps * fix: v2 detail history back * fix: v2 detail history back * tweak: url params * fix: memo url time range * fix: memo url time range * fix: conprof * chore: time range * update deps * chore * chore * chore * update copyright * skip e2e * Fix/time range selector (#1459) * chore: update time limit level * chore: update time limit level * chore: update time range selector no overview page * chore: update tidb dashboard for clinic cloud version * centos7 build image * cleanup dockerfiles * Revert mistake commits (#1465) * Revert "cleanup dockerfiles" This reverts commit 98f0964. * Revert "centos7 build image" This reverts commit 320b30c. * Centos7 dockerfile; fix tests (#1467) * centos7 build image (cherry picked from commit 320b30c) * cleanup dockerfiles (cherry picked from commit 98f0964) * fix centos7 build; fix test * fix test * chore: update tooltip when failed to get host info (#1469) - because the reason is not correct in some cases * chore: add serverless monitoring (#1462) * chore: add serverless monitoring * chore: remove category from serverless category * chore: refine code and update failed query promql * chore: update promql * fix: time range limit on time range selector * fix: date should be available if there are available hours on this date * chore: update time limit * chore: fix slowquery rout prefix * chore: fix route prefix of diagnosis app * fix(topsql): short format (#1476) * feat(slowquery): add warnings (#1472) * feat(slowquery): add warnings * fix: lint generic * chore: types * fix: test * fix: test * fix: tests * [Feature] Manually bind execution plan (#1473) * Backend for binding sql plan feature (#1471) * default version value for local quick startup * update CONTRIBUTING.md * done backend * fix swag doc * fix query bug * done * fix feature version check * fix lint * revert swagger tag * fix 404 response (#1474) * fix null response * fix get plan response; fix drop plan behavior. * fix * fix dockerfile * fix supported version check * Add one-click bind plan on sql statement detail page (#1475) * chore: add plan bind api * chore: add plan bind modal * chore: destory modal content on close * chore: fix plan table selection * chore: update plan bind style * chore: add i18n to bind plan * chore: set selection as radio on plan bind table * chore: update plan selection status * chore: set plan list order by plan count * chore: refine code * chore: refine code * replace reflection go-funk with generic lo; add more fields to query plan response * update swag * add error message * fix format * chore: update enable plan binding condition * fix tests * chore: update go.mod * chore: refine code * fix centos7 dockerfile * fix typo --------- Co-authored-by: Yini Xu <[email protected]> Co-authored-by: YiniXu9506 <[email protected]> Co-authored-by: Suhaha <[email protected]> * Update release version --------- Co-authored-by: Yini Xu <[email protected]> Co-authored-by: Yifan Xu <[email protected]> Co-authored-by: Sparkle <[email protected]> Co-authored-by: YiniXu9506 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only take effect on cloud side.