-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TiKV config: Add new online configurations and update value ranges #7964
TiKV config: Add new online configurations and update value ranges #7964
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: TomShawn <[email protected]>
Co-authored-by: TomShawn <[email protected]>
@TomShawn all comments have been addressed, PTAL, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/remove-status LGT1 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e2ca977
|
What is changed, added or deleted? (Required)
raftstore.raft-max-inflight-msgs
,readpool.unified.max-thread-count
max-thread-count
,num-threads
raft-max-inflight-msgs
,apply-pool-size
(the changes for this configuration's description are the same as changes in PR TiKV config: Update some values and add new online configurations #7963, line 738).Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?