Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv: add some new online configurations #8676

Merged
merged 11 commits into from
Mar 25, 2022
Merged

tikv: add some new online configurations #8676

merged 11 commits into from
Mar 25, 2022

Conversation

ethercflow
Copy link
Contributor

Signed-off-by: Wenbo Zhang [email protected]

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • en-jin19

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 15, 2022 09:58
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2022
@en-jin19 en-jin19 self-requested a review March 15, 2022 10:02
@en-jin19 en-jin19 self-assigned this Mar 15, 2022
@en-jin19 en-jin19 added translation/doing This PR’s assignee is translating this PR. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.0 This PR/issue applies to TiDB v6.0. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed missing-translation-status This PR does not have translation status info. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 15, 2022
@ethercflow
Copy link
Contributor Author

ethercflow commented Mar 15, 2022 •
edited
Loading

PTAL @NingLin-P thanks!

@ethercflow ethercflow requested a review from NingLin-P March 15, 2022 10:58
NingLin-P
NingLin-P reviewed Mar 15, 2022
View reviewed changes
dynamic-config.md Outdated
Comment on lines 126 to 127
| raftstore.raft-max-inflight-msgs | 待确认日志个数的数量，如果超过这个数量将会减缓发送日志的个数 |
| raftstore.raft-entry-max-size | 单个日志最大大小 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz remove raftstore.raft-entry-max-size

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@ethercflow ethercflow requested a review from NingLin-P March 16, 2022 13:26
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2022
@en-jin19 en-jin19 added the status/PTAL This PR is ready for reviewing. label Mar 22, 2022
TomShawn
TomShawn reviewed Mar 23, 2022
View reviewed changes
dynamic-config.md Outdated
@@ -123,7 +123,7 @@ show warnings;

| 配置项 | 简介 |
| --- | --- |
| raftstore.raft-entry-max-size | 单个日志最大大小 |
| raftstore.raft-max-inflight-msgs | 待确认的日志个数，如果超过这个数量，Raft 状态机会减缓发送日志的个数 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“减缓发送日志的个数”读起来不通

TomShawn
TomShawn reviewed Mar 23, 2022
View reviewed changes
TomShawn
TomShawn reviewed Mar 23, 2022
View reviewed changes
tikv-configuration-file.md Outdated
@@ -528,7 +532,7 @@ raftstore 相关的配置项。
>
> 该配置项不支持通过 SQL 语句查询，但支持在配置文件中进行配置。

+ 待确认日志个数的数量，如果超过这个数量将会减缓发送日志的个数。
+ 待确认的日志个数，如果超过这个数量，Raft 状态机会减缓发送日志的个数。
Copy link
Contributor

@TomShawn TomShawn Mar 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

【减缓发送日志的个数】读起来有些奇怪

en-jin19
en-jin19 reviewed Mar 24, 2022
View reviewed changes
TomShawn
TomShawn reviewed Mar 24, 2022
View reviewed changes
tikv-configuration-file.md Outdated
Comment on lines 1495 to 1496
+ 默认值：CPU * 0.5，但最大为 8
+ 可调整范围：1 ~ CPU
Copy link
Contributor

@TomShawn TomShawn Mar 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> 和 < 容易被误判为标签，能否使用“大于”“小于”这样的文字描述呢？

en-jin19
en-jin19 approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@en-jin19 en-jin19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2022
@en-jin19
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@en-jin19: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@en-jin19
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2022
@en-jin19
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 05ce6d9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2022
@ti-chi-bot ti-chi-bot merged commit bb9cd57 into pingcap:master Mar 25, 2022
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Mar 28, 2022
@en-jin19 en-jin19 mentioned this pull request Mar 28, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@en-jin19 en-jin19 en-jin19 approved these changes

@NingLin-P NingLin-P NingLin-P approved these changes

Assignees

@en-jin19 en-jin19

Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.0 This PR/issue applies to TiDB v6.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ethercflow @ti-chi-bot @en-jin19 @NingLin-P @TomShawn