Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql-statements: update ddl assertions behavior #3787

Merged
merged 11 commits into from Sep 23, 2020
Merged

sql-statements: update ddl assertions behavior #3787

merged 11 commits into from Sep 23, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 1, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

Update docs for PR pingcap/tidb#19162

The way DDL assertions behave has changed slightly. There will be small version conflicts, since I noticed that the ALTER DATABASE page has the Chinese word for synopsis in it: https://docs.pingcap.com/tidb/stable/sql-statement-alter-database -- I will fix it in the cherry pick.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ghost ghost added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. needs-cherry-pick-4.0 labels Sep 1, 2020
@ghost ghost requested a review from kolbe September 1, 2020 16:15
@TomShawn TomShawn requested review from zz-jason and lilin90 September 3, 2020 08:12
@TomShawn TomShawn added size/medium Changes of a medium size. translation/doing This PR's assignee is translating this PR. status/PTAL This PR is ready for reviewing. labels Sep 3, 2020
@TomShawn TomShawn self-assigned this Sep 3, 2020
kolbe
kolbe reviewed Sep 3, 2020
View reviewed changes
Copy link
Contributor

@kolbe kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@kolbe,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ti-srebot
Copy link
Contributor

@kolbe, @zz-jason, @lilin90, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@kolbe, @zz-jason, @lilin90, PTAL.

zz-jason
zz-jason approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 9, 2020
@ti-srebot
Copy link
Contributor

@kolbe, @zz-jason, @lilin90, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@kolbe, @zz-jason, @lilin90, PTAL.

lilin90
lilin90 reviewed Sep 14, 2020
View reviewed changes
@lilin90 lilin90 added the status/require-change Needs the author to address comments. label Sep 14, 2020
Null not nil and others added 7 commits September 13, 2020 20:52
@ti-srebot
Copy link
Contributor

@kolbe, @zz-jason, @lilin90, PTAL.

@ti-srebot
Copy link
Contributor

@nullnotnil, please update your pull request.

@ghost ghost removed the status/require-change Needs the author to address comments. label Sep 16, 2020
@ti-srebot
Copy link
Contributor

@kolbe, @zz-jason, @lilin90, PTAL.

@ti-srebot
Copy link
Contributor

@nullnotnil, please update your pull request.

@ti-srebot
Copy link
Contributor

@nullnotnil, please update your pull request.

@ti-srebot
Copy link
Contributor

@kolbe, @zz-jason, @lilin90, PTAL.

@ti-srebot
Copy link
Contributor

@nullnotnil, please update your pull request.

@lilin90 lilin90 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 23, 2020
lilin90
lilin90 approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 6222617 into pingcap:master Sep 23, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 23, 2020
@ti-srebot
cherry pick pingcap#3787 to release-4.0
da8f156 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 23, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3958

ghost pushed a commit that referenced this pull request Sep 23, 2020
@ti-srebot
sql-statements: update ddl assertions behavior (#3787) (#3958)
a5b168e 
* cherry pick #3787 to release-4.0

Signed-off-by: ti-srebot <[email protected]>

* Update sql-statement-alter-database.md

Co-authored-by: Null not nil <[email protected]>
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Oct 14, 2020
@TomShawn TomShawn mentioned this pull request Oct 14, 2020
Merged
9 tasks
This was referenced Jan 6, 2021
Merged
Merged
@TomShawn TomShawn removed the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TomShawn TomShawn

Labels
size/medium Changes of a medium size. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @kolbe @zz-jason @lilin90 @TomShawn