Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql-statements: update ddl assertions behavior (#4680) #5272

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #4680 to release-5.0

What is changed, added or deleted? (Required)

Update docs for PR pingcap/tidb#19162

The way DDL assertions behave has changed slightly. There will be small version conflicts, since I noticed that the ALTER DATABASE page has the Chinese word for synopsis in it: https://docs.pingcap.com/tidb/stable/sql-statement-alter-database -- I will fix it in the cherry pick.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 6, 2021
@TomShawn TomShawn merged commit f0faf75 into pingcap:release-5.0 Jan 6, 2021
@TomShawn TomShawn deleted the release-5.0-1d406758a0a1 branch April 29, 2021 10:08
@TomShawn
Copy link
Contributor

/type 4.0-cherry-pick

@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. label Apr 29, 2021
@TomShawn
Copy link
Contributor

/remove-type 4.0-cherry-pick
/type 5.0-cherry-pick

@ti-chi-bot ti-chi-bot added type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. and removed type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants