Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NaN support #100

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Add NaN support #100

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
70f2f36
Add `NaN` tests
mkgrgis May 23, 2024
026d6ef
Implement possible `NaN` support
mkgrgis May 30, 2024
9413bed
Fixes by PR review
mkgrgis Jun 17, 2024
b03bbec
Fix auto test
mkgrgis Jun 17, 2024
9cc95e3
Fix switches
mkgrgis Jun 17, 2024
07552a8
Fix swithes by review
mkgrgis Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 107 additions & 19 deletions expected/12.16/extra/float4.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1240,6 +1240,9 @@ INSERT INTO "type_FLOAT_INF" (i, f) VALUES (13, 'Inf');
INSERT INTO "type_FLOAT_INF" (i, f) VALUES (14, '+Inf');
--Testcase 288:
INSERT INTO "type_FLOAT_INF" (i, f) VALUES (15, '-Inf');
--Testcase 289: Inserted as NULL!!!
--see https://github.com/sqlite/sqlite/blob/6db0b11e078f4b651f0cf00f845f3d77700c1a3a/src/vdbemem.c#L973
INSERT INTO "type_FLOAT_INF" (i, f) VALUES (16, 'NaN');
--Testcase 290:
ALTER FOREIGN TABLE "type_FLOAT_INF" ALTER COLUMN "f" TYPE text;
--Testcase 291:
Expand All @@ -1255,7 +1258,7 @@ INSERT INTO "type_FLOAT_INF" (i, f) VALUES (21, '+Inf');
--Testcase 296:
INSERT INTO "type_FLOAT_INF" (i, f) VALUES (22, '-Inf');
--Testcase 297:
--INSERT INTO "type_FLOAT_INF" (i, f) VALUES (23, 'NaN');
INSERT INTO "type_FLOAT_INF" (i, f) VALUES (23, 'NaN');
--Testcase 298:
INSERT INTO "type_FLOAT_INF" (i, f) VALUES (24, 'Infinity__');
--Testcase 299:
Expand Down Expand Up @@ -1293,13 +1296,15 @@ SELECT * FROM "type_FLOAT_INF";
13 | Infinity
14 | Infinity
15 | -Infinity
16 |
17 | Infinity
18 | Infinity
19 | -Infinity
20 | Infinity
21 | Infinity
22 | -Infinity
(19 rows)
23 | NaN
(21 rows)

--Testcase 306:
SELECT * FROM "type_FLOAT_INF+";
Expand All @@ -1318,13 +1323,15 @@ SELECT * FROM "type_FLOAT_INF+";
13 | Infinity | real | 3
14 | Infinity | real | 3
15 | -Infinity | real | 4
16 | | null |
17 | Infinity | text | 8
18 | Infinity | text | 9
19 | -Infinity | text | 9
20 | Infinity | text | 3
21 | Infinity | text | 4
22 | -Infinity | text | 4
(19 rows)
23 | NaN | text | 3
(21 rows)

--Testcase 307:
SELECT * FROM "type_FLOAT_INF+" ORDER BY f ASC, i;
Expand All @@ -1349,12 +1356,16 @@ SELECT * FROM "type_FLOAT_INF+" ORDER BY f ASC, i;
18 | Infinity | text | 9
20 | Infinity | text | 3
21 | Infinity | text | 4
(19 rows)
23 | NaN | text | 3
16 | | null |
(21 rows)

--Testcase 308:
SELECT * FROM "type_FLOAT_INF+" ORDER BY f DESC, i;
i | f | t | l
----+-----------+------+---
16 | | null |
23 | NaN | text | 3
2 | Infinity | real | 3
4 | Infinity | real | 3
10 | Infinity | real | 3
Expand All @@ -1374,13 +1385,14 @@ SELECT * FROM "type_FLOAT_INF+" ORDER BY f DESC, i;
15 | -Infinity | real | 4
19 | -Infinity | text | 9
22 | -Infinity | text | 4
(19 rows)
(21 rows)

--Testcase 309:
SELECT * FROM "type_FLOAT_INF+" WHERE f > '+Infinity' ORDER BY i;
i | f | t | l
---+---+---+---
(0 rows)
i | f | t | l
----+-----+------+---
23 | NaN | text | 3
(1 row)

--Testcase 310:
SELECT * FROM "type_FLOAT_INF+" WHERE f < '+Infinity' ORDER BY i;
Expand Down Expand Up @@ -1415,9 +1427,10 @@ SELECT * FROM "type_FLOAT_INF+" WHERE f = '+Infinity' ORDER BY i;

--Testcase 312:
SELECT * FROM "type_FLOAT_INF+" WHERE f > '+Inf' ORDER BY i;
i | f | t | l
---+---+---+---
(0 rows)
i | f | t | l
----+-----+------+---
23 | NaN | text | 3
(1 row)

--Testcase 313:
SELECT * FROM "type_FLOAT_INF+" WHERE f < '+Inf' ORDER BY i;
Expand Down Expand Up @@ -1467,7 +1480,8 @@ SELECT * FROM "type_FLOAT_INF+" WHERE f > '-Infinity' ORDER BY i;
18 | Infinity | text | 9
20 | Infinity | text | 3
21 | Infinity | text | 4
(13 rows)
23 | NaN | text | 3
(14 rows)

--Testcase 316:
SELECT * FROM "type_FLOAT_INF+" WHERE f < '-Infinity' ORDER BY i;
Expand Down Expand Up @@ -1504,7 +1518,8 @@ SELECT * FROM "type_FLOAT_INF+" WHERE f > '-Inf' ORDER BY i;
18 | Infinity | text | 9
20 | Infinity | text | 3
21 | Infinity | text | 4
(13 rows)
23 | NaN | text | 3
(14 rows)

--Testcase 319:
SELECT * FROM "type_FLOAT_INF+" WHERE f < '-Inf' ORDER BY i;
Expand All @@ -1526,9 +1541,10 @@ SELECT * FROM "type_FLOAT_INF+" WHERE f = '-Inf' ORDER BY i;

--Testcase 321:
SELECT * FROM "type_FLOAT_INF+" WHERE f > 'Infinity' ORDER BY i;
i | f | t | l
---+---+---+---
(0 rows)
i | f | t | l
----+-----+------+---
23 | NaN | text | 3
(1 row)

--Testcase 322:
SELECT * FROM "type_FLOAT_INF+" WHERE f < 'Infinity' ORDER BY i;
Expand Down Expand Up @@ -1563,9 +1579,10 @@ SELECT * FROM "type_FLOAT_INF+" WHERE f = 'Infinity' ORDER BY i;

--Testcase 324:
SELECT * FROM "type_FLOAT_INF+" WHERE f > 'Inf' ORDER BY i;
i | f | t | l
---+---+---+---
(0 rows)
i | f | t | l
----+-----+------+---
23 | NaN | text | 3
(1 row)

--Testcase 325:
SELECT * FROM "type_FLOAT_INF+" WHERE f < 'Inf' ORDER BY i;
Expand Down Expand Up @@ -1598,6 +1615,44 @@ SELECT * FROM "type_FLOAT_INF+" WHERE f = 'Inf' ORDER BY i;
21 | Infinity | text | 4
(10 rows)

--Testcase 327:
SELECT * FROM "type_FLOAT_INF+" WHERE f > 'NaN' ORDER BY i;
i | f | t | l
---+---+---+---
(0 rows)

--Testcase 328:
SELECT * FROM "type_FLOAT_INF+" WHERE f < 'NaN' ORDER BY i;
i | f | t | l
----+-----------+------+---
1 | -Infinity | real | 4
2 | Infinity | real | 3
3 | -Infinity | real | 4
4 | Infinity | real | 3
5 | -1e+308 | real | 9
6 | 0 | real | 3
7 | 1e+308 | real | 8
10 | Infinity | real | 3
11 | Infinity | real | 3
12 | -Infinity | real | 4
13 | Infinity | real | 3
14 | Infinity | real | 3
15 | -Infinity | real | 4
17 | Infinity | text | 8
18 | Infinity | text | 9
19 | -Infinity | text | 9
20 | Infinity | text | 3
21 | Infinity | text | 4
22 | -Infinity | text | 4
(19 rows)

--Testcase 329:
SELECT * FROM "type_FLOAT_INF+" WHERE f = 'NaN' ORDER BY i;
i | f | t | l
----+-----+------+---
23 | NaN | text | 3
(1 row)

--Testcase 330:
EXPLAIN (VERBOSE, COSTS OFF)
SELECT * FROM "type_FLOAT_INF+" WHERE f > '+Infinity' ORDER BY i;
Expand Down Expand Up @@ -1796,6 +1851,39 @@ SELECT * FROM "type_FLOAT_INF+" WHERE f = 'Inf' ORDER BY i;
SQLite query: SELECT `i`, sqlite_fdw_float(`f`), `t`, `l` FROM main."type_FLOAT_INF+" WHERE ((sqlite_fdw_float(`f`) = 9e999))
(6 rows)

--Testcase 348:
EXPLAIN (VERBOSE, COSTS OFF)
SELECT * FROM "type_FLOAT_INF+" WHERE f > 'NaN' ORDER BY i;
QUERY PLAN
-------------------------------------------------------------------------------------------------------------------------------------------------------------
Foreign Scan on public."type_FLOAT_INF+"
Output: i, f, t, l
SQLite query: SELECT `i`, sqlite_fdw_float(`f`), `t`, `l` FROM main."type_FLOAT_INF+" WHERE ((sqlite_fdw_float(`f`) > 'NaN')) ORDER BY `i` ASC NULLS LAST
(3 rows)

--Testcase 349:
EXPLAIN (VERBOSE, COSTS OFF)
SELECT * FROM "type_FLOAT_INF+" WHERE f < 'NaN' ORDER BY i;
QUERY PLAN
-------------------------------------------------------------------------------------------------------------------------------------------------------------
Foreign Scan on public."type_FLOAT_INF+"
Output: i, f, t, l
SQLite query: SELECT `i`, sqlite_fdw_float(`f`), `t`, `l` FROM main."type_FLOAT_INF+" WHERE ((sqlite_fdw_float(`f`) < 'NaN')) ORDER BY `i` ASC NULLS LAST
(3 rows)

--Testcase 350:
EXPLAIN (VERBOSE, COSTS OFF)
SELECT * FROM "type_FLOAT_INF+" WHERE f = 'NaN' ORDER BY i;
QUERY PLAN
---------------------------------------------------------------------------------------------------------------------------------------
Sort
Output: i, f, t, l
Sort Key: "type_FLOAT_INF+".i
-> Foreign Scan on public."type_FLOAT_INF+"
Output: i, f, t, l
SQLite query: SELECT `i`, sqlite_fdw_float(`f`), `t`, `l` FROM main."type_FLOAT_INF+" WHERE ((sqlite_fdw_float(`f`) = 'NaN'))
(6 rows)

--Testcase 351:
DELETE FROM "type_FLOAT_INF" WHERE i >= 10;
--Testcase 352:
Expand Down
Loading
Loading