-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NaN
support
#100
Add NaN
support
#100
Conversation
Hello, @t-kataym ! Which calendar plans have pgspider team to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mkgrgis ,
Thank you for your support.
I have reviewed your PR. Could you please check it?
Yes, @MinhLA1410 ! All of your comments are checked. All problems should be fixed in 9413bed. Please verify. |
After merging of this PR #36 can be closed. |
@MinhLA1410 , any updates? |
@mkgrgis Thank you for your contribution. I will merge it. |
This implementation methodologically bases on
text
affinity values in foreign tables #66NaN
ignore codeThis PR implements
NaN
as readable value from SQLite if there is such case insensitive value withtext
affinity.According ISO:SQL and implemented PostgreSQL code we can input
NaN
as special IEEE-754 value through API or as special text constant through SQL. SQLite doesn't supportNaN
withreal
affinity (in opposition to ±∞ values) and doesn't rewritesNULL
value ifNaN
is detected. Hence in this PRNaN
is readable and detectable but not writeable.About changes:
NaN
implementation was untested outside ofaggregates
test, 70f2f36 adds tests for previous implementation,NaN
value withtext
affinity in SQLite.