Drop support for legacy Python 2 #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hugovk
commented
Oct 19, 2019
hugovk
commented
- Fixes Drop python 2 support #194.
- Replaces and closes Drop support for legacy Python 2 #301.
This was referenced Oct 19, 2019
Closed
|
I've found this reference to python 2. I have no idea what the argument is for. The argument |
|
Removing that would change the API, what do you suggest? |
|
Once python2 is removed it does not serve a function anymore. (I guess, because I do not really know what its function is anyway). So we should remove it at some point. Also, I am not seeing anyone actually using it on github. I've created issue #324 for deprecating it in the next release (in 2 weeks or so). So lets remove it. |
|
I've recreated this PR in #346 so I can rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.