-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add requirements.txt #300
Add requirements.txt #300
Conversation
Actually, this should probably include a step that exercises more parts of the code, such as the PIL reference mentioned in #299. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @charlesreid1,
Thanks for your PR!
Is there any particular reason that you included the versions of those packages? My personal preference is to to specify only the major version of the package.
Also, like you said, PIL is also a dependency of pdfminerl.six.
The setup.py should also be updated in this PR.
The .travis.yml should also be updated by this PR.
requirements.txt
Outdated
@@ -0,0 +1,6 @@ | |||
chardet==3.0.4 | |||
nose==1.3.7 | |||
pdfminer.six==20181108 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pdfminer.six is not a depencency of pdfminer.six ;)
@charlesreid1 what do you think of my additional remark:
|
chardet==3.0.4 | ||
nose==1.3.7 | ||
pycryptodome==3.9.0 | ||
six==1.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
six can be removed after #305 is merged
Please see #306 for an alternative. |
Closes #299
Procedure to create/update requirements.txt: