Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements.txt #300

Closed
wants to merge 3 commits into from
Closed

Add requirements.txt #300

wants to merge 3 commits into from

Conversation

charlesreid1
Copy link
Contributor

@charlesreid1 charlesreid1 commented Oct 17, 2019

Closes #299

Procedure to create/update requirements.txt:

# clone the pdfminer.six repo
git clone https://github.com/pdfminer/pdfminer.six.git
# create a virtual environment
virtualenv vp && source vp/bin/activate`
# install the pdfminer.six package
python setup.py build install
# freeze requirements
pip freeze > requirements.txt

@charlesreid1
Copy link
Contributor Author

Actually, this should probably include a step that exercises more parts of the code, such as the PIL reference mentioned in #299.

Copy link
Member

@pietermarsman pietermarsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @charlesreid1,

Thanks for your PR!

Is there any particular reason that you included the versions of those packages? My personal preference is to to specify only the major version of the package.

Also, like you said, PIL is also a dependency of pdfminerl.six.

The setup.py should also be updated in this PR.

The .travis.yml should also be updated by this PR.

requirements.txt Outdated
@@ -0,0 +1,6 @@
chardet==3.0.4
nose==1.3.7
pdfminer.six==20181108
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pdfminer.six is not a depencency of pdfminer.six ;)

@pietermarsman pietermarsman added the type: development Related to the development process for maintainers label Oct 17, 2019
@pietermarsman
Copy link
Member

@charlesreid1 what do you think of my additional remark:

Is there any particular reason that you included the versions of those packages? My personal preference is to to specify only the major version of the package.

Also, like you said, PIL is also a dependency of pdfminerl.six.

The setup.py should also be updated in this PR.

The .travis.yml should also be updated by this PR.

chardet==3.0.4
nose==1.3.7
pycryptodome==3.9.0
six==1.12.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

six can be removed after #305 is merged

@hugovk
Copy link
Contributor

hugovk commented Oct 19, 2019

Please see #306 for an alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: development Related to the development process for maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add requirements.txt file for developpers
3 participants